Closed Bug 1572905 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18362 - Use |LayoutBox::ContentLogicalHeight| value for atomic inline FlexBox.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18362 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18362
Details from upstream follow.

Joonghun Park <pjh0718@gmail.com> wrote:

Use |LayoutBox::ContentLogicalHeight| value for atomic inline FlexBox.

Before this CL, |LayoutBox::ComputeIntrinsicLogicalContentHeightUsing|
returns zero intrinsic size defined in |LayoutBox::IntrinsicSize|,
when atomic inline level flexbox's height is specified with
'height: min-content'.

Per spec, https://drafts.csswg.org/css-sizing/#valdef-width-min-content,

"min-content
If specified for the inline axis, use the min-content inline size;
otherwise compute to auto.",

'height' property specified with min-content should compute to 'auto',
i.e. the content's intrinsic size.

Bug: 959551
Change-Id: I798a07670036072bfd47bddb6bb0f88347eaa929
Reviewed-on: https://chromium-review.googlesource.com/1746507
WPT-Export-Revision: 0788a2264e1501eccc871f24189dab6efa348934

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07b8d6a18ea
[wpt PR 18362] - Use |LayoutBox::ContentLogicalHeight| value for atomic inline FlexBox., a=testonly

https://hg.mozilla.org/mozilla-central/rev/c07b8d6a18ea

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.