Closed Bug 1572976 Opened 2 years ago Closed 2 years ago

Use gTreeUtils in permissionsManager and cookieViewer

Categories

(SeaMonkey :: Passwords & Permissions, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.67
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

Rather than duplicating code we might as well make use of gTreeUtils

Attached patch Use gTreeUtils patch (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky):None
String changes made by this patch:None

Attachment #9084515 - Flags: review?(frgrahl)
Attachment #9084515 - Flags: approval-comm-release?
Attachment #9084515 - Flags: approval-comm-esr60?
Depends on: 1209626

NIT while we are on it

suite/components/permissions/content/cookieViewer.js
permissionsTreeView.selection.select(-1); could be changed to permissionsTreeView.selection.clearSelection();

Attached patch 1572976-use_treeUtils-253.patch (obsolete) — Splinter Review

Rebased 2.53 patch with the nit fix for 2.53

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

NIT while we are on it

suite/components/permissions/content/cookieViewer.js
permissionsTreeView.selection.select(-1); could be changed to permissionsTreeView.selection.clearSelection();

That's done over in Bug 1572129 which this applies on top of.

Attachment #9084528 - Attachment is obsolete: true

Unbitrotted to go on top of patches in bug 1209626 and bug 1572129

Attachment #9084515 - Attachment is obsolete: true
Attachment #9084515 - Flags: review?(frgrahl)
Attachment #9084515 - Flags: approval-comm-release?
Attachment #9084515 - Flags: approval-comm-esr60?
Attachment #9084533 - Flags: review?(frgrahl)
Attachment #9084533 - Flags: approval-comm-release?
Attachment #9084533 - Flags: approval-comm-esr60?
Comment on attachment 9084533 [details] [diff] [review]
Use gTreeUtils patch v1.1

Nice cleanup
Attachment #9084533 - Flags: review?(frgrahl)
Attachment #9084533 - Flags: review+
Attachment #9084533 - Flags: approval-comm-release?
Attachment #9084533 - Flags: approval-comm-release+
Attachment #9084533 - Flags: approval-comm-esr60?
Attachment #9084533 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/dd4e0a33f3ea
Use gTreeUtils in permissionsManager and cookieViewer. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.