1572976 - Use gTreeUtils in permissionsManager and cookieViewer

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, enhancement)

Description

[Ian Neal]

Rather than duplicating code we might as well make use of gTreeUtils

Comment 1

[Ian Neal]

Attachment: Use gTreeUtils patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky):None
String changes made by this patch:None

Comment 2

[Frank-Rainer Grahl (:frg)]

NIT while we are on it

suite/components/permissions/content/cookieViewer.js
permissionsTreeView.selection.select(-1); could be changed to permissionsTreeView.selection.clearSelection();

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1572976-use_treeUtils-253.patch

Rebased 2.53 patch with the nit fix for 2.53

Comment 4

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

NIT while we are on it

suite/components/permissions/content/cookieViewer.js
permissionsTreeView.selection.select(-1); could be changed to permissionsTreeView.selection.clearSelection();

That's done over in Bug 1572129 which this applies on top of.

Comment 5

[Ian Neal]

Attachment: Use gTreeUtils patch v1.1

Unbitrotted to go on top of patches in bug 1209626 and bug 1572129

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9084533 [details] [diff] [review]
Use gTreeUtils patch v1.1

Nice cleanup

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd4e0a33f3ea
Use gTreeUtils in permissionsManager and cookieViewer. r=frg

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/5a912babe8be5a38c89de23f8ef4d66c9192b83c

Comment 9

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/693e74c6256f37dac14673e53f12870de1c419c6