157298 - make install does not work in mozilla/widget/src/gtk2/mai

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Marco Pesenti Gritti]

bash-2.05a$ make install
updating widget/src/gtk2/mai/Makefile
../../../../config/nsinstall -t -m 644  /opt/gnome/include/mozilla-1.1a+/mai
usage: ../../../../config/nsinstall [-C cwd] [-L linkprefix] [-m mode] [-o
owner] [-g group]
                                    [-DdltR] file [file ...] directory
make: *** [install] Error 2

Comment 1

[Marco Pesenti Gritti]

Attachment: proposed fix

Comment 2

[Kyle Yuan]

John should take a look at this problem.

Comment 3

[John Sun]

This patch is correct. Thank mpeseng!
Kyle, could you pls help to add r= and check in the patch?

Comment 4

[Kyle Yuan]

Comment on attachment 91221 [details] [diff] [review]
proposed fix

ok, r=kyle

but I'm not sure whether we can check in without a=? I prefer to check in this
when trunk re-opened.

Comment 5

[John Sun]

Ok,thanks!

Comment 6

[Kyle Yuan]

checked in!

Comment 7

[Matthias Versen [:Matti]]

AFAIK : You need an a= if the tree is open.

see http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
and the very big status at the top

Comment 8

[Kyle Yuan]

Matti, yes, we know this policy, but this stuff is not a part of the build
before gtk2 becomes the default graphics environment.

Comment 9

[Marco Pesenti Gritti]

For some reason the patch has been reverted by this commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&root=/cvsroot&subdir=mozilla/widget/src/gtk2/mai&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4
make install is borked again, so I reopen this.

Comment 10

[Bolian Yin]

Oh, It is my fault. I will fix it soon.

Comment 11

[Bolian Yin]

checked in trunk.