Closed Bug 157298 Opened 22 years ago Closed 22 years ago

make install does not work in mozilla/widget/src/gtk2/mai

Categories

(Core :: XUL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mpgritti, Assigned: john.sun)

References

Details

Attachments

(1 file)

bash-2.05a$ make install
updating widget/src/gtk2/mai/Makefile
../../../../config/nsinstall -t -m 644  /opt/gnome/include/mozilla-1.1a+/mai
usage: ../../../../config/nsinstall [-C cwd] [-L linkprefix] [-m mode] [-o
owner] [-g group]
                                    [-DdltR] file [file ...] directory
make: *** [install] Error 2
Blocks: 145863
Attached patch proposed fixSplinter Review
John should take a look at this problem.
Assignee: jaggernaut → john.sun
This patch is correct. Thank mpeseng!
Kyle, could you pls help to add r= and check in the patch?
Comment on attachment 91221 [details] [diff] [review]
proposed fix

ok, r=kyle

but I'm not sure whether we can check in without a=? I prefer to check in this
when trunk re-opened.
Attachment #91221 - Flags: review+
Ok,thanks!
Status: NEW → ASSIGNED
checked in!
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
AFAIK : You need an a= if the tree is open.

see http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
and the very big status at the top
Matti, yes, we know this policy, but this stuff is not a part of the build
before gtk2 becomes the default graphics environment.
For some reason the patch has been reverted by this commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&root=/cvsroot&subdir=mozilla/widget/src/gtk2/mai&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4
make install is borked again, so I reopen this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh, It is my fault. I will fix it soon.
checked in trunk.
Status: REOPENED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: