Use BytecodeLocation and BytecodeIterator in JitScript::printTypes
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: asorholm, Assigned: asorholm)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=c++])
Attachments
(1 file)
Currently in JitScript::printTypes, bytecode is manipulated directly with the use of jsbytecode* and pcToOffset. The goal of this bug is to encapsulate that manipulation with the bytecode interface classes BytecodeLocation and BytecodeIterator.
|
||
Updated•5 years ago
|
Replaced uses of jsbytecode* and pcToOffset with the bytecode
interface classes BytecodeLocation and BytecodeIterator.
New try build due to internal server errors encountered with the previous try build, that weren't resolved by rerunning the failed jobs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27d92bb2fd02129a12583dc278b1fe94a741ac5d
Try build with missing BytecodeIterator-inl.h header in jit/JitScript.cpp fixed, that was source of linker errors in previous try builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a40f396ac9e767dcb0c5b5a65e471fed633d4b8
Try build with all of the linker problems fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a36a9e7dbb13835edaa3c0b35b783d59a404ca98
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9554c2b0527e
Use BytecodeLocation and BytecodeIterator in JitScript::printTypes. r=mgaudet
|
||
Comment 7•5 years ago
|
||
Backed out changeset 9554c2b0527e (Bug 1573062) for build bustages at JitScript.cpp.
Backout: https://hg.mozilla.org/integration/autoland/rev/0f4444606b29ea0cf710bfc79558a3905c7ee72a
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=9554c2b0527edeadd1d72e6c677ded89cd02498b&selectedJob=270411733
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270411733&repo=autoland&lineNumber=33010
(In reply to Cristian Brindusan [:cbrindusan] from comment #7)
Backed out changeset 9554c2b0527e (Bug 1573062) for build bustages at JitScript.cpp.
Backout: https://hg.mozilla.org/integration/autoland/rev/0f4444606b29ea0cf710bfc79558a3905c7ee72a
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=9554c2b0527edeadd1d72e6c677ded89cd02498b&selectedJob=270411733
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270411733&repo=autoland&lineNumber=33010
Oh wow, that was my mistake. My apologies! I included the missing headers, and created a new try build, but neglected to update the phabricator revision with the updated patch. I've updated the phabricator revision with the updated patch now.
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3253e345e0db
Use BytecodeLocation and BytecodeIterator in JitScript::printTypes. r=mgaudet
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
Description
•