1573140 - adjustCertInformation function is pushing undefined and empty elements (about:certificate)

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Comment 1

[Carolina Jimenez Gomez]

Attachment: Expected.png

Comment 2

[Carolina Jimenez Gomez]

Attachment: Got_undefineds.png

Comment 3

[Carolina Jimenez Gomez]

Attachment: Got_empty.png

Comment 4

[Carolina Jimenez Gomez]

Attachment: Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Depends on D41534

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed6b561f0ea
Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Comment 7

[Andrei Ciure[:aciure]]

Backed out changeset 5ed6b561f0ea (bug 1573140) for causing ESlint failres

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=5ed6b561f0eac353ca492fdc9017673f3b94ccd1

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=a3f2cf3e1bb4a9ab091f0dcf0e8eca7ed0283768&selectedJob=261596983&searchStr=linting%2Copt%2Csource-test-mozlint-eslint%2C%28es%29

backout: https://hg.mozilla.org/integration/autoland/rev/786e33943f52dc58c86bf477158c689265ce928c

Comment 8

[Carolina Jimenez Gomez]

Thank you, I'm going to work on it

Comment 9

[Hassan Lukosi Kibiti [:elimuhub]]

Comment on attachment 9084789 [details]
Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Fixes adjustCertInformation

Comment 10

[Narcis Beleuzu [:NarcisB]]

Land failed with:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmplwdiwJ toolkit/components/certviewer/tests/browser/browser.ini Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file toolkit/components/certviewer/tests/browser/browser.ini.rej abort: patch command failed: exited with status 256

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b60425e31501
Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b60425e31501

Comment 13

[Maria Berlinger [:mberlinger], Services QA]

I've managed to reproduce this issue using Firefox 70.0a1 (20190811215021).
This is verified fixed using Firefox 71.0a1 ( 20191006214844) on the following OSes: Windows 10x64, Ubuntu 18.04x64 and macOS 10.13.