Closed Bug 1573140 Opened 5 months ago Closed 5 months ago

adjustCertInformation function is pushing undefined and empty elements (about:certificate)

Categories

(Firefox :: Security, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: carolina.jimenez.g, Assigned: carolina.jimenez.g)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

No description provided.
Attached image Expected.png
Attached image Got_undefineds.png
Attached image Got_empty.png
Blocks: 1553524
Depends on: 1573139
Status: NEW → ASSIGNED
Priority: -- → P1
Duplicate of this bug: 1573139
Attachment #9084789 - Attachment description: Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh Bug 1573140 - Adds test to check non empty strings are being rendered. → Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannhBug 1573140 - Adds test to check non empty strings are being rendered.
Attachment #9084789 - Attachment description: Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannhBug 1573140 - Adds test to check non empty strings are being rendered. → Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ed6b561f0ea
Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Keywords: checkin-needed

Thank you, I'm going to work on it

Flags: needinfo?(carolina.jimenez.g)

Comment on attachment 9084789 [details]
Bug 1573140 - Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Fixes adjustCertInformation

Keywords: checkin-needed

Land failed with:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmplwdiwJ toolkit/components/certviewer/tests/browser/browser.ini Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file toolkit/components/certviewer/tests/browser/browser.ini.rej abort: patch command failed: exited with status 256

Flags: needinfo?(carolina.jimenez.g)
Flags: needinfo?(carolina.jimenez.g)
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b60425e31501
Fixes adjustCertInformation function to avoid returning empty or undefined elements.r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I've managed to reproduce this issue using Firefox 70.0a1 (20190811215021).
This is verified fixed using Firefox 71.0a1 ( 20191006214844) on the following OSes: Windows 10x64, Ubuntu 18.04x64 and macOS 10.13.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.