Closed Bug 1573152 Opened 5 years ago Closed 5 years ago

Use NewbornArrayPush to append array values in Intl code

Categories

(Core :: JavaScript: Internationalization API, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Using NewbornArrayPush instead of DefineDataElement can give a slight performance improvement in µ-benchmarks (up to 5%) and additionally aligns Intl code with the rest of SpiderMonkey, where NewbornArrayPush is preferred over DefineDataElement to fill arrays.

Attachment #9084675 - Attachment description: Bug 1573152: Use NewbornArrayPush to append values to new arrays. r=mgaudet! → Bug 1573152: Use NewbornArrayPush to append values to new arrays. r=jwalden!

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad6647c380c7
Use NewbornArrayPush to append values to new arrays. r=jwalden

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: