1573184 - Create gtest for decoder benchmark

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

Add gtest when possibly in decoder benchmark classes.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1573184 - Update comments in TestAudioCallbackDriver. r?jya

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1573184 - Add unit tests to KeyValueStorage class. r?jya

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1573184 - Add gtests to BenchmarkStorage classes. r?jya

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1573184 - Add unit test to DecoderBenchmark. r?jya

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b2f517fe428
Update comments in TestAudioCallbackDriver. r=jya
https://hg.mozilla.org/integration/autoland/rev/ffd7b6d1c83e
Add unit tests to KeyValueStorage class. r=jya
https://hg.mozilla.org/integration/autoland/rev/a56fabd724f6
Add gtests to BenchmarkStorage classes. r=jya
https://hg.mozilla.org/integration/autoland/rev/dd058b64c376
Add unit test to DecoderBenchmark. r=jya

Comment 6

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=d07f2e7d6f5e0e37a739dbd93d7bebe3fc831ba9&fromchange=dd058b64c37630503925d6743b5c7a3c9127fb9f&selectedJob=261376819

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261376819&repo=autoland&lineNumber=32949

Backout link: https://hg.mozilla.org/integration/autoland/rev/005a25a9284857594f1bb1dd44b18a215d59a86a

[task 2019-08-13T17:37:39.071Z] 17:37:39 INFO - /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_dom_media_gtest2.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DHAVE_UINT64_T -DWEBRTC_POSIX -DWEBRTC_BUILD_LIBEVENT -DWEBRTC_LINUX -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/media/gtest -I/builds/worker/workspace/build/src/obj-firefox/dom/media/gtest -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/common -I/builds/worker/workspace/build/src/media/webrtc/trunk -I/builds/worker/workspace/build/src/media/webrtc/trunk/webrtc -I/builds/worker/workspace/build/src/gfx/2d -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/media -I/builds/worker/workspace/build/src/dom/media/encoder -I/builds/worker/workspace/build/src/dom/media/gmp -I/builds/worker/workspace/build/src/dom/media/mp4 -I/builds/worker/workspace/build/src/dom/media/platforms -I/builds/worker/workspace/build/src/dom/media/platforms/agnostic -I/builds/worker/workspace/build/src/security/certverifier -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -Wno-error=shadow -Wno-unused-private-field -MD -MP -MF .deps/Unified_cpp_dom_media_gtest2.o.pp /builds/worker/workspace/build/src/obj-firefox/dom/media/gtest/Unified_cpp_dom_media_gtest2.cpp
[task 2019-08-13T17:37:39.073Z] 17:37:39 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dom/media/gtest/Unified_cpp_dom_media_gtest2.cpp:2:
[task 2019-08-13T17:37:39.073Z] 17:37:39 ERROR - /builds/worker/workspace/build/src/dom/media/gtest/TestOpusParser.cpp:16:18: error: use of undeclared identifier 'OpusParser'; did you mean 'mozilla::OpusParser'?
[task 2019-08-13T17:37:39.073Z] 17:37:39 INFO - bool found = OpusParser::IsValidMapping2ChannelsCount(channels);
[task 2019-08-13T17:37:39.073Z] 17:37:39 INFO - ^~~~~~~~~~
[task 2019-08-13T17:37:39.073Z] 17:37:39 INFO - mozilla::OpusParser
[task 2019-08-13T17:37:39.073Z] 17:37:39 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/OpusParser.h:14:7: note: 'mozilla::OpusParser' declared here
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - class OpusParser {
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - ^
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - 1 error generated.
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - /builds/worker/workspace/build/src/config/rules.mk:787: recipe for target 'Unified_cpp_dom_media_gtest2.o' failed
[task 2019-08-13T17:37:39.074Z] 17:37:39 ERROR - make[4]: *** [Unified_cpp_dom_media_gtest2.o] Error 1
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/gtest'
[task 2019-08-13T17:37:39.074Z] 17:37:39 INFO - make[4]: *** Waiting for unfinished jobs....

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de0b1d5a9b6d
Update comments in TestAudioCallbackDriver. r=jya
https://hg.mozilla.org/integration/autoland/rev/53882dede69a
Add unit tests to KeyValueStorage class. r=jya
https://hg.mozilla.org/integration/autoland/rev/5cea00ec9038
Add gtests to BenchmarkStorage classes. r=jya
https://hg.mozilla.org/integration/autoland/rev/2c56720051ee
Add unit test to DecoderBenchmark. r=jya

Comment 8

[Alex Chronopoulos [:achronop]]

Clearing the NI.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/de0b1d5a9b6d
https://hg.mozilla.org/mozilla-central/rev/53882dede69a
https://hg.mozilla.org/mozilla-central/rev/5cea00ec9038
https://hg.mozilla.org/mozilla-central/rev/2c56720051ee