Closed Bug 1573196 Opened 3 years ago Closed 3 years ago

[Documentation] Fix GeckoWebExecutor variable naming in example code provided

Categories

(GeckoView :: General, defect, P3)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(firefox69 wontfix, firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: awaseem, Assigned: awaseem)

Details

Attachments

(1 file)

Bug 1573196 - Fixed GeckoWebExecutor documentation.
47 bytes, text/x-phabricator-request
Details | Review

In the example provided in the docs for GeckoWebExecutor, the lambda function takes in response, which is already defined to be a GeckoResult. That variable needs to be renamed to something else in order to be compilable.

https://searchfox.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoWebExecutor.java#34

Assignee: nobody → awaseem
status-firefox69: --- → wontfix
status-firefox70: --- → affected
Priority: -- → P3
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c5e22cd2378
Fixed GeckoWebExecutor documentation. r=geckoview-reviewers,snorp

https://hg.mozilla.org/mozilla-central/rev/1c5e22cd2378

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.