1573382 - testAlarmDialog.js is failing a lot lately

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

testAlarmDialog.js is failing a lot lately, for example here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=236122c254bd492b454a7b307e6a173268691d34&selectedJob=261165823

or mostly on try confusing people:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2ba6abed2358dd28b1be2ec16cf0d3ac972baddc&selectedJob=261226459
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d741572aebe01d00324b9c4fb11fa5aee7b6e352&selectedJob=261184603
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=85ca9466365a343459a1e51ef3e87e5644181bb3&selectedJob=261099251

https://taskcluster-artifacts.net/eRdgLiuLTxC0voP8WdsqqA/0/public/logs/live_backing.log
EXCEPTION: Timeout waiting for modal dialog to open.

Comment 1

[Geoff Lankow (:darktrojan)]

I've noticed this too, and I think I may have a way to fix it. I need to run it on Try a few times.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1573382-test-alarm-dialog-1.diff

This seems to do the trick. I don't know why it's started happening more recently, but looking at the change I made I'm surprised it didn't fail more.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9085009 [details] [diff] [review]
1573382-test-alarm-dialog-1.diff

Review of attachment 9085009 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just a couple comment edits for clarity.  Huzzah for fewer randomly failing tests!

::: calendar/test/mozmill/eventDialog/testAlarmDialog.js
@@ +59,5 @@
>              allday: true,
>              reminder: "1day",
>          });
>  
> +        // Dismiss the alarm.

For clarity, lets change this comment to "Prepare to dismiss the alarm." since the alarm hasn't happened yet.

@@ +76,5 @@
>          let { eid: eventid } = helpersForController(event);
>  
>          setData(event, iframe, { reminder: "2days" });
>  
> +        // Snooze the alarm.

Same here: "Prepare to snooze the alarm."

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c4e99f8017a7
Plan for alarm dialog earlier, in testAlarmDialog.js. r=pmorris

Comment 5

[Jorg K (CEST = GMT+2)]

Landed with comments adjusted.