Open Bug 1573398 Opened 5 years ago Updated 5 years ago

Lando incorrectly rewrote r= with multiple reviewers

Categories

(Conduit :: Lando, defect, P2)

Product:
Conduit
Component:
Lando
Version:
Production
Type:
defect

Tracking

(Not tracked)

People

(Reporter: jonco, Unassigned)

Details

(Keywords: conduit-triaged)

I landed a patch which in its final version was uploaded to phabricator with the following commit message:

Bug 1407593 - Report embedding leaks of JS GC things r=mccr8,sfink?

When I landed this with lando it was rewritten to:

Bug 1407593 - Report embedding leaks of JS GC things r=sfink,sfink?

It seems to have handled multiple reviewers incorrectly.

(It's just been pointed out to me that I'm supposed to use r?foo with lando rather than r=foo? which I didn't realise).

Parsing free-form text is fun.

What happened was r=mccr8,sfink? was parsed as a single reviewer mccr8, with ,sfink? as trailing characters. As sfink was the sole reviewer of the revision, mccr8's name was replaced with sfink, resulting in r=sfink,sfink?

Keywords: conduit-triaged
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.