Closed
Bug 1573432
Opened 5 years ago
Closed 5 years ago
[mozdevice] make adb.py python 3 compatible
Categories
(Testing :: Mozbase, defect, P3)
Tracking
(firefox70 fixed)
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: tarek, Assigned: tarek)
References
Details
Attachments
(1 file)
There are a couple of stops where it crashes on python 3 (bytes vs str). I have a version that works, I'll push a patch.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
•
|
||
These changes will fix the API that read values out of ADB commands.
Notice that the current tests mock everything that comes out
of commands, that's why we did not get these errors and the adb
module is not well covered in the tests.
One solution would be to remove all the mocking and have our
own fake adb process running and sending back some values
so we could test all the file reading in python 2 and 3.
|
||
Updated•5 years ago
|
Attachment #9085372 -
Attachment description: Bug 1573432 - make adb.py python 3 compatible r?whimboo → Bug 1573432 - make adb.py python 3 compatible r?bc
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7147a64ff7b make adb.py python 3 compatible r=bc
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•