1573470 - Restarting TB while Calendar tab is open at times gives two toolbars

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: two calendar toolbars.png

Restarting TB while Calendar tab is open at times gives two toolsbars.

I see that in TB 68 and TB 69, but not in a local build. Maybe because it's slower.

Comment 1

[Geoff Lankow (:darktrojan)]

I've seen this before but of course when I want it to happen to investigate, I can't make it happen.

Looks like we're not getting to this line which probably means commonInitCalendar is throwing an exception.

Comment 2

[Jorg K (CEST = GMT+2)]

All I can say is that it happens to me 90% of the time.

Comment 4

[Jorg K (CEST = GMT+2)]

Geoff, Paul, people out in the field are starting to complain, I've just reproduced it myself.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1573470-wait-for-xbl-esr1.diff

I found several problems, all related to things happening in the wrong order. Might as well fix them all at once.

This patch only applies to comm-esr68. I don't think any of the things it fixes are a problem in anything later, because they're XBL problems. Possibly the modebox one is, and if so we can port it.

Comment 6

[Jorg K (CEST = GMT+2)]

Great if we could get this fixed for TB 68.1 now.

Paul, doing a try run for Linux is probably your best bet for testing. If you have any doubt, talk to me on IRC.

Comment 7

[Geoff Lankow (:darktrojan)]

Maybe like this one: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=78a5c80e24aa02ace173f5feb5867193ac0f50b0

Comment 8

[Paul Morris [:pmorris]]

Comment on attachment 9090328 [details] [diff] [review]
1573470-wait-for-xbl-esr1.diff

Review of attachment 9090328 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. r=pmorris

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/aa3f64e3934efa99c8488aab51e598ceea7f62e3

Comment 10

[Jorg K (CEST = GMT+2)]

Nice try, but it didn't help. I get two toolbars when opening TB to the calendar tab and the Calendar tab icon is messed up as well like before. That's using a month view.

It happens every time when I use the add-on "Lightning Calendar Tabs" (available at ATN), and it happens much rarer without the add-on.

Also I see:
weekLabel is null calendar-month-base-view.js:503
relayout chrome://calendar/content/calendar-month-base-view.js:503
execute chrome://calendar/content/calendar-base-view.js:259
addItemsFromCalendar chrome://calendar/content/calendar-base-view.js:797
refresh chrome://calendar/content/calendar-base-view.js:776
setDateRange chrome://calendar/content/calendar-month-base-view.js:299
showDate chrome://calendar/content/calendar-month-base-view.js:248
goToDay chrome://calendar/content/calendar-views.js:269
switchToView chrome://calendar/content/calendar-views-utils.js:288
ltnSwitch2Calendar chrome://lightning/content/messenger-overlay-sidebar.js:632
openTab chrome://lightning/content/messenger-overlay-sidebar.js:72
openTab chrome://messenger/content/tabmail.xml:610
restoreTab chrome://lightning/content/messenger-overlay-sidebar.js:99
restoreTab chrome://messenger/content/tabmail.xml:1087
registerTabType chrome://messenger/content/tabmail.xml:366

Comment 11

[Jorg K (CEST = GMT+2)]

Mr Spitznagel, would you like a link to a pre-release so you can try it out also with respect to the other bugs your filed, bug 1578196 and bug 1577989. If so, for which platform?

Comment 12

[Geoff Lankow (:darktrojan)]

The line containing the reference to weekLabel isn't 503 any more, we added 8 lines and it's now 511. You must have a cached file.

Comment 13

[Jorg K (CEST = GMT+2)]

Grrrr, I though about having to force an upgrade ... and forgot. Too many things cooking at once :-(

Comment 14

[Jorg K (CEST = GMT+2)]

What a fight to get LN updated if you have one from a previous TB 68.1 :-( - The extensions.lastAppVersion trick didn't seem to work.

It works now, thanks. There is still quite a show going on, at first, two toolbars are displayed and then after a split second, one disappears.

Comment 15

[d.spitznagel]

Hello Jork K, yes please.
Currently we use 32bit but I would also like to test 64bit - both if possible - but at least 32bit.

Comment 16

[Jorg K (CEST = GMT+2)]

Hmm, you didn't mention the platform. I assume Windows. It will be in English though:
32bit: https://queue.taskcluster.net/v1/task/b1ItT68HT0uJA9jkhbd7Eg/runs/0/artifacts/public/build/install/sea/target.installer.exe
64bit: https://queue.taskcluster.net/v1/task/SjTUxTb9R_KxV9bGaOlVjg/runs/0/artifacts/public/build/install/sea/target.installer.exe

Comment 17

[d.spitznagel]

Sorry, I meant Windows so you were right.
I have tested this with the 32bit version above and the problem is "partly" fixed.
The cursor still spins forever and the icon is also still wrong (should be calendar icon).

Hmm, would like to add screenshot, but cannot?!

Comment 18

[Jorg K (CEST = GMT+2)]

"Attach New File" button above. Try to keep the screenshot small.

Comment 19

[d.spitznagel]

Attachment: calendar.jpg

screenshot attached

Comment 20

[Jorg K (CEST = GMT+2)]

I tried it a few times and I didn't see a spinning cursor or broken icon. To me it looks 99.9% fixed apart from the occasional show of seeing things move around before they finally fall into place.

Comment 21

[d.spitznagel]

Jork K, I looked deeper into this and discovered the following...

Currently I use for testing TB 68 these plugins:
TbSync
Provider for CalDAV & CardDAV
LookOut (fix version)
Quicktext.
These are the plugins we absolutely need.

Disabled all > test > OK (calendar tab looks like it should).
Enabled TbSync > test > OK > Disabled Tbsync.
Enabled Provider for CalDAV & CardDAV > test > OK > Disabled Provider for CalDAV & CardDAV.
Enabled LookOut > test > NOT OK > Disabled Lookout.
Enabled Quicktext > test > NOT OK > Disabled Quicktext.

Quicktext and LookOut are the only plugins that need a "Restart" when enabled - not the other two!!
As far as I remember correctly, TB 68 release notes say something about that plugins do NOT need any "Restart" anymore.

Is this problem related to NOT 100% compatible plugins with the new TB 68 Engine or a problem in TB itself???
Can someone of your team give me "evidence" so that I know who I should contact to solve this problem?
Can you also test on your side If you can reproduce this with Quicktext or Lookout (fix version)?