1573473 - Create global "normalize" function to make items kebab-case

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P3)

Description

[danielleleb12]

Replace all instances of this:
this.item.sectionTitle.replace(/\s+/g, "-").toLowerCase()

with a normalizing function.

Comment 1

[danielleleb12]

Attachment: Bug 1573473 - Creates global function to make strings kebab-case. r=johannh

Depends on D41610

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39212af55f82
Creates global function to make strings kebab-case. r=johannh

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=browser%2Cchrome&revision=39212af55f82f9fd9ca7310e8af60e54c702523c&selectedJob=262347518

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=262347518&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=262347687&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=262346777&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/eb80ebd4ac1d91d04e842658f75860d859f4dd11

[task 2019-08-19T21:19:33.074Z] 21:19:33 INFO - TEST-PASS | toolkit/components/certviewer/tests/browser/browser_checkNonEmptyFields.js | There must at least one tab - 3 > 0 -
[task 2019-08-19T21:19:33.075Z] 21:19:33 INFO - Buffered messages finished
[task 2019-08-19T21:19:33.076Z] 21:19:33 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/certviewer/tests/browser/browser_checkNonEmptyFields.js | Uncaught exception - TypeError: tabButton is null
[task 2019-08-19T21:19:33.077Z] 21:19:33 INFO - GECKO(7244) | JavaScript error: , line 0: uncaught exception: [fluent] Missing translations in en-US: certificate-viewer-not-before-utc, certificate-viewer-not-after-utc, certificate-viewer-download.
[task 2019-08-19T21:19:33.080Z] 21:19:33 INFO - Leaving test bound test
[task 2019-08-19T21:19:33.081Z] 21:19:33 INFO - Console message: [JavaScript Error: "TypeError: this.shadowRoot.querySelector(...) is null" {file: "chrome://global/content/certviewer/components/certificate-section.js" line: 59}]
[task 2019-08-19T21:19:33.082Z] 21:19:33 INFO - addClassForPadding@chrome://global/content/certviewer/components/certificate-section.js:59:8
[task 2019-08-19T21:19:33.082Z] 21:19:33 INFO - render@chrome://global/content/certviewer/components/certificate-section.js:51:10
[task 2019-08-19T21:19:33.083Z] 21:19:33 INFO - connectedCallback@chrome://global/content/certviewer/components/certificate-section.js:27:10
[task 2019-08-19T21:19:33.084Z] 21:19:33 INFO - render@chrome://global/content/certviewer/certviewer.js:391:34
[task 2019-08-19T21:19:33.085Z] 21:19:33 INFO - asyncbuildChain/<@chrome://global/content/certviewer/certviewer.js:418:14
[task 2019-08-19T21:19:33.085Z] 21:19:33 INFO - promise callbackbuildChain@chrome://global/content/certviewer/certviewer.js:413:6
[task 2019-08-19T21:19:33.086Z] 21:19:33 INFO - @chrome://global/content/certviewer/certviewer.js:20:9
[task 2019-08-19T21:19:33.087Z] 21:19:33 INFO - EventListener.handleEvent*@chrome://global/content/certviewer/certviewer.js:12:10
[task 2019-08-19T21:19:33.088Z] 21:19:33 INFO -
[task 2019-08-19T21:19:33.089Z] 21:19:33 INFO - Console message: [JavaScript Error: "uncaught exception: [fluent] Missing translations in en-US: certificate-viewer-not-before-utc, certificate-viewer-not-after-utc, certificate-viewer-download."]
[task 2019-08-19T21:19:33.089Z] 21:19:33 INFO - GECKO(7244) | MEMORY STAT | vsize 2879MB | residentFast 364MB | heapAllocated 133MB
[task 2019-08-19T21:19:33.090Z] 21:19:33 INFO - TEST-OK | toolkit/components/certviewer/tests/browser/browser_checkNonEmptyFields.js | took 1594ms

[task 2019-08-19T21:18:29.656Z] 21:18:29 INFO - TEST-INFO | screentopng: exit 0
[task 2019-08-19T21:18:29.658Z] 21:18:29 INFO - Buffered messages logged at 21:18:28
[task 2019-08-19T21:18:29.659Z] 21:18:29 INFO - Entering test bound testCAandTitle
[task 2019-08-19T21:18:29.660Z] 21:18:29 INFO - Buffered messages finished
[task 2019-08-19T21:18:29.660Z] 21:18:29 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-08-19T21:18:29.665Z] 21:18:29 INFO - Leaving test bound testCAandTitle
[task 2019-08-19T21:18:29.666Z] 21:18:29 INFO - Entering test bound testSSLEndEntity
[task 2019-08-19T21:18:29.666Z] 21:18:29 INFO - Console message: [JavaScript Error: "TypeError: this.shadowRoot.querySelector(...) is null" {file: "chrome://global/content/certviewer/components/certificate-section.js" line: 59}]
[task 2019-08-19T21:18:29.667Z] 21:18:29 INFO - addClassForPadding@chrome://global/content/certviewer/components/certificate-section.js:59:8
[task 2019-08-19T21:18:29.667Z] 21:18:29 INFO - render@chrome://global/content/certviewer/components/certificate-section.js:51:10
[task 2019-08-19T21:18:29.668Z] 21:18:29 INFO - connectedCallback@chrome://global/content/certviewer/components/certificate-section.js:27:10
[task 2019-08-19T21:18:29.668Z] 21:18:29 INFO - render@chrome://global/content/certviewer/certviewer.js:391:34
[task 2019-08-19T21:18:29.669Z] 21:18:29 INFO - asyncbuildChain/<@chrome://global/content/certviewer/certviewer.js:418:14
[task 2019-08-19T21:18:29.669Z] 21:18:29 INFO - promise callbackbuildChain@chrome://global/content/certviewer/certviewer.js:413:6
[task 2019-08-19T21:18:29.671Z] 21:18:29 INFO - @chrome://global/content/certviewer/certviewer.js:20:9
[task 2019-08-19T21:18:29.671Z] 21:18:29 INFO - EventListener.handleEvent*@chrome://global/content/certviewer/certviewer.js:12:10
[task 2019-08-19T21:18:29.671Z] 21:18:29 INFO -
[task 2019-08-19T21:18:29.672Z] 21:18:29 INFO - Console message: [JavaScript Error: "uncaught exception: [fluent] Missing translations in en-US: certificate-viewer-not-before-utc, certificate-viewer-not-after-utc, certificate-viewer-download."]
[task 2019-08-19T21:18:29.924Z] 21:18:29 INFO - GECKO(3736) | JavaScript error: chrome://global/content/certviewer/components/certificate-section.js, line 59: TypeError: this.shadowRoot.querySelector(...) is null
[task 2019-08-19T21:18:29.947Z] 21:18:29 INFO - GECKO(3736) | JavaScript error: , line 0: uncaught exception: [fluent] Missing translations in en-US: certificate-viewer-not-before-utc, certificate-viewer-not-after-utc, certificate-viewer-download.
[task 2019-08-19T21:18:29.950Z] 21:18:29 INFO - Console message: [JavaScript Error: "TypeError: this.shadowRoot.querySelector(...) is null" {file: "chrome://global/content/certviewer/components/certificate-section.js" line: 59}]
[task 2019-08-19T21:18:29.950Z] 21:18:29 INFO - addClassForPadding@chrome://global/content/certviewer/components/certificate-section.js:59:8
[task 2019-08-19T21:18:29.950Z] 21:18:29 INFO - render@chrome://global/content/certviewer/components/certificate-section.js:51:10
[task 2019-08-19T21:18:29.951Z] 21:18:29 INFO - connectedCallback@chrome://global/content/certviewer/components/certificate-section.js:27:10
[task 2019-08-19T21:18:29.951Z] 21:18:29 INFO - render@chrome://global/content/certviewer/certviewer.js:391:34
[task 2019-08-19T21:18:29.952Z] 21:18:29 INFO - asyncbuildChain/<@chrome://global/content/certviewer/certviewer.js:418:14
[task 2019-08-19T21:18:29.953Z] 21:18:29 INFO - promise callbackbuildChain@chrome://global/content/certviewer/certviewer.js:413:6
[task 2019-08-19T21:18:29.953Z] 21:18:29 INFO - @chrome://global/content/certviewer/certviewer.js:20:9
[task 2019-08-19T21:18:29.954Z] 21:18:29 INFO - EventListener.handleEvent*@chrome://global/content/certviewer/certviewer.js:12:10
[task 2019-08-19T21:18:29.954Z] 21:18:29 INFO -
[task 2019-08-19T21:18:29.955Z] 21:18:29 INFO - Console message: [JavaScript Error: "uncaught exception: [fluent] Missing translations in en-US: certificate-viewer-not-before-utc, certificate-viewer-not-after-utc, certificate-viewer-download."]
[task 2019-08-19T21:18:29.971Z] 21:18:29 INFO - Not taking screenshot here: see the one that was previously logged

Comment 4

[danielleleb12]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2947871e919e0351d7bc066381d8d8de5282c6a&selectedJob=262367059 - tests passing successfully now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5688ffc96dd8
Creates global function to make strings kebab-case. r=johannh

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5688ffc96dd8