Closed Bug 1573477 Opened 4 months ago Closed 3 months ago

Support Scalar operations in GeckoView Streaming Telemetry

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Design doc's here: https://docs.google.com/document/d/1IHnHPmHr4X3oTOHaC3rGVM-sajMtNEJAi7kgIzTENKs/edit#

We'll need:

  • support for the geckoview_streaming product in Scalars.yaml (already done as part of bug 1566352)
  • Redirection from scalar operations to the streaming batch accumulator
  • Additional API surface in StreamingTelemetryDelegate to handle Scalar operations
  • Doc updates
  • Test coverage

Biggest open question in the doc relevant to this work is whether we support ScalarAdd() or ScalarSet() for uint Scalars. Maybe both?

Open question's closed: We'll be only supporting ScalarSet() for the moment across all Scalar types.

Blocks: 1576730
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40184cc13f08
Geckoview Streaming Telemetry: Scalar part r=janerik,agi
https://hg.mozilla.org/integration/autoland/rev/66f2bbd8c21e
Add asserting impls for new Streaming Telemetry interface methods r=agi
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.