Closed Bug 1573493 Opened 1 year ago Closed 1 year ago

Search panel is missing two prefs

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Honza, Assigned: lloanalas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The search panel is using two prefs, but default values are not defined and there is an exception when opening that panel.

Exception
columnNumber: 0
data: null
filename: "resource://devtools/client/netmonitor/src/components/MonitorPanel.js"
lineNumber: 163
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
message: "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]"
name: "NS_ERROR_UNEXPECTED"
result: 2147549183

stack: "renderSearchPanel@resource://devtools/client/netmonitor/src/components/MonitorPanel.js:163:41

@Lloan, two prefs need to be defined in devtools-client.js

diff --git a/devtools/client/preferences/devtools-client.js b/devtools/client/preferences/devtools-client.js
--- a/devtools/client/preferences/devtools-client.js
+++ b/devtools/client/preferences/devtools-client.js
@@ -167,16 +167,18 @@ pref("devtools.netmonitor.enabled", true
 pref("devtools.netmonitor.features.search", false);
 
 // Enable the Application panel
 pref("devtools.application.enabled", false);
 
 // The default Network Monitor UI settings
 pref("devtools.netmonitor.panes-network-details-width", 550);
 pref("devtools.netmonitor.panes-network-details-height", 450);
+pref("devtools.netmonitor.panes-search-width", 550);
+pref("devtools.netmonitor.panes-search-height", 450);
 pref("devtools.netmonitor.filters", "[\"all\"]");
 pref("devtools.netmonitor.visibleColumns",
   "[\"status\",\"method\",\"domain\",\"file\",\"cause\",\"type\",\"transferred\",\"contentSize\",\"waterfall\"]"
 );
 pref("devtools.netmonitor.columnsData",
   '[{"name":"status","minWidth":30,"width":5}, {"name":"method","minWidth":30,"width":5}, {"name":"domain","minWidth":30,"width":10}, {"name":"file","minWidth":30,"width":25}, {"name":"url","minWidth":30,"width":25}, {"name":"cause","minWidth":30,"width":10},{"name":"type","minWidth":30,"width":5},{"name":"transferred","minWidth":30,"width":10},{"name":"contentSize","minWidth":30,"width":5},{"name":"waterfall","minWidth":150,"width":25}]');
 pref("devtools.netmonitor.ws.payload-preview-height", 128);
 pref("devtools.netmonitor.ws.visibleColumns",

Please create Phab patch and test with new profile making sure this helps.

Honza

Assignee: nobody → lloanalas
Blocks: 1572145
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7eafb0d4ad6
Search panel is missing two prefs. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.