Closed
Bug 1573526
Opened 5 years ago
Closed 5 years ago
Use gTreeUtils in pageinfo
Categories
(SeaMonkey :: Page Info, enhancement)
SeaMonkey
Page Info
Tracking
(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.67
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file, 1 obsolete file)
|
7.33 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Port parts that have not previous done of:
- Bug 275223 - Enable Tree View Columns to be Sorted in Page Info
including making use of gTreeUtils
[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky):None
String changes made by this patch:None
Moved towards mozilla implementation, but happier with using cycleHeader/doSort than their onPageMediaSort so kept that for the moment.
Attachment #9085118 -
Flags: review?(frgrahl)
Attachment #9085118 -
Flags: approval-comm-release?
Attachment #9085118 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9085118 [details] [diff] [review] pageinfo gTreeUtils One down. More to come r/a+ As discussed. Should use ChromeUtils.import now in 2.53.
Attachment #9085118 -
Flags: review?(frgrahl)
Attachment #9085118 -
Flags: review+
Attachment #9085118 -
Flags: approval-comm-release?
Attachment #9085118 -
Flags: approval-comm-release+
Attachment #9085118 -
Flags: approval-comm-esr60?
Attachment #9085118 -
Flags: approval-comm-esr60+
Carrying forward r/a+
Attachment #9085118 -
Attachment is obsolete: true
Attachment #9086247 -
Flags: review+
Attachment #9086247 -
Flags: approval-comm-release+
Attachment #9086247 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b0e783e5a80c
Use gTreeUtils in pageinfo. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•5 years ago
|
||
Type: task → enhancement
status-seamonkey2.49esr:
--- → wontfix
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.63:
--- → wontfix
Target Milestone: --- → seamonkey2.67
Whiteboard: SM2.53.1
You need to log in
before you can comment on or make changes to this bug.
Description
•