Closed Bug 1573537 Opened 1 year ago Closed 1 year ago

fix parenthesizing property info static_assert for dom bindings

Categories

(Core :: DOM: Bindings (WebIDL), task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

PVS Studio complains about this:

obj-x86_64-pc-linux-gnu/dom/bindings/AbortControllerBinding.cpp	198	err	V634 The priority of the '*' operation is higher than that of the '<<' operation. It's possible that parentheses should be used in the expression.

and we use parentheses in the iterator alias expression mere lines away from this one. We might as well be consistent.

Otherwise we're computing (1ull << CHAR_BIT) * sizeof(...), which is not
quite what we wanted.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b86930a9d34
add parentheses for property info count `static_assert`; r=bzbarsky
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.