1573588 - Changes to Events.yaml are not available to mochitests when using artifact builds

Status: RESOLVED WORKSFORME

(Toolkit :: Telemetry, defect, P2)

Description

[Rehan Dalal (Inactive)]

I added a new entry to the "objects" array for a few events and these changes were not getting picked up by mochitest and causing my tests to fail. I noticed this in my patch on bug 1436111.

I've created a minimal patch that recreates the issue for me.

It's probably worth nothing that :mythmon who was reviewing the patch on the other bug was not able to reproduce the issue. So it appears to be intermittent.

Comment 1

[Rehan Dalal (Inactive)]

Attachment: Bug 1573588 - Minimal patch to demonstrate issue with Events.yaml

Comment 2

[Chris H-C :chutten]

Might be related to bug 1572758 where events aren't recording/showing properly.

Comment 3

[Michael Cooper [:mythmon]]

I tried this patch both with an artifact build and with a normal build, and both worked fine for me. I did both of my tests on Linux, if that matters, though I used two separate machines.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:chutten, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Chris H-C :chutten]

(Lowish priority pending what bug 1572758 turns up)

Comment 6

[Mathieu Leplatre [:leplatrem]]

FWIW I'm having this issue with xpcshell too (https://bugzilla.mozilla.org/show_bug.cgi?id=1448945#c55)

Comment 7

[Matthew N. [:MattN]]

Any chance this can be higher priority now that bug 1619990 is fixed?

Comment 8

[Jan-Erik Rediger [:janerik]]

Sure, should probably be a similar fix. I need to see if I find some time still this week, but now that my next week opened up I can prioritize it.

Comment 9

[Jan-Erik Rediger [:janerik]]

I took a look at this and couldn't reproduce either.
Mochitests start a full browser and thus also the full Telemetry module, meaning it picks up changed metrics in artifact builds.

For artifact builds the Telemetry build system generates a $OBJDIR/dist/bin/EventArtifactDefinitions.json file.
If you encounter a problem again please check if your changes are reflected in that file (happy to assist with that) and let us know.

For now I'm closing this.