Closed Bug 1573646 Opened 8 months ago Closed 8 months ago

avoid nsCOMPtr temporary in nsContentList::PopulateSelf

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

No description provided.

Due to C++ rules about how the ternary ?: operator works, the third
operand here was getting coerced to an nsCOMPtr, which was then
immediately destroyed. We can avoid the refcounting traffic by making
the type of both operands match.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d239094a8dd4
avoid nsCOMPtr temporary in nsContentList::PopulateSelf; r=mccr8
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.