Closed Bug 1573658 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18407 - CSS: Shortest serialization for gap shorthand

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18407 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18407
Details from upstream follow.

Eric Willigers <ericwilligers@chromium.org> wrote:

CSS: Shortest serialization for gap shorthand

gap is \<'row-gap'> \<'column-gap'>?
https://drafts.csswg.org/css-align-3/#propdef-gap

If row-gap and column-gap are the same, we serialize
only a single value, consistent with Firefox and
the shortest representation principle.
https://drafts.csswg.org/cssom/#serializing-css-values

Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77
Reviewed-on: https://chromium-review.googlesource.com/1750521
WPT-Export-Revision: 7816abc924ac918a7394e83feeac4da533574c6b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 6 tests and 27 subtests OK : 6 PASS : 13 FAIL : 14 New tests that have failures or other problems: /css/css-align/parsing/gap-computed.html Property gap value '10px 20%' computes to '10px 20%': FAIL Property gap value '10px' computes to '10px': FAIL Property gap value '20% calc(20% + 10px)' computes to '20% calc(20% + 10px)': FAIL Property gap value '20%' computes to '20%': FAIL Property gap value 'calc(-0.5em + 10px) calc(0.5em + 10px)' computes to '0px 30px': FAIL Property gap value 'calc(-0.5em + 10px)' computes to '0px': FAIL Property gap value 'calc(0.5em + 10px)' computes to '30px': FAIL Property gap value 'calc(20% + 10px) normal' computes to 'calc(20% + 10px) normal': FAIL Property gap value 'calc(20% + 10px)' computes to 'calc(20% + 10px)': FAIL Property gap value 'normal 10px' computes to 'normal 10px': FAIL Property gap value 'normal' computes to 'normal': FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4c1f1890b3 [wpt PR 18407] - CSS: Shortest serialization for gap shorthand, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/b0bc01a70855 [wpt PR 18407] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8e4c1f1890b3
https://hg.mozilla.org/mozilla-central/rev/b0bc01a70855

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.