Closed Bug 1573738 Opened 3 months ago Closed 3 months ago

Intermittent [TV] toolkit/components/places/tests/sync/test_bookmark_abort_merging.js | test_abort_merging - [test_abort_merging : 1] Missing expected exception Should abort merge when signaled

Categories

(Firefox :: Sync, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Lina, NeedInfo)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files)

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=261492925&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/ZkfcTxk7SRqR_ubruKDNVg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ZkfcTxk7SRqR_ubruKDNVg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2019-08-14T01:50:12.850Z] 01:50:12 INFO - TEST-START | toolkit/components/places/tests/sync/test_bookmark_abort_merging.js
[task 2019-08-14T01:50:13.284Z] 01:50:13 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/sync/test_bookmark_abort_merging.js | xpcshell return code: 0
[task 2019-08-14T01:50:13.285Z] 01:50:13 INFO - TEST-INFO took 430ms
[task 2019-08-14T01:50:13.285Z] 01:50:13 INFO - >>>>>>>
[task 2019-08-14T01:50:13.286Z] 01:50:13 INFO - PID 3132 | *** You are running in chaos test mode. See ChaosMode.h. ***
[task 2019-08-14T01:50:13.286Z] 01:50:13 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-08-14T01:50:13.287Z] 01:50:13 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-08-14T01:50:13.287Z] 01:50:13 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-08-14T01:50:13.288Z] 01:50:13 INFO - running event loop
[task 2019-08-14T01:50:13.289Z] 01:50:13 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2019-08-14T01:50:13.289Z] 01:50:13 INFO - toolkit/components/places/tests/sync/test_bookmark_abort_merging.js | Starting test_abort_merging
[task 2019-08-14T01:50:13.290Z] 01:50:13 INFO - (xpcshell/head.js) | test test_abort_merging pending (2)
[task 2019-08-14T01:50:13.290Z] 01:50:13 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2019-08-14T01:50:13.291Z] 01:50:13 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/sync/test_bookmark_abort_merging.js | test_abort_merging - [test_abort_merging : 1] Missing expected exception Should abort merge when signaled
[task 2019-08-14T01:50:13.291Z] 01:50:13 INFO - -e:null:1
[task 2019-08-14T01:50:13.292Z] 01:50:13 INFO - exiting test
[task 2019-08-14T01:50:13.293Z] 01:50:13 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2019-08-14T01:50:13.294Z] 01:50:13 INFO - _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:788:20
[task 2019-08-14T01:50:13.294Z] 01:50:13 INFO - do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:889:23
[task 2019-08-14T01:50:13.295Z] 01:50:13 INFO - Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:66:21
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - proto.report@resource://testing-common/Assert.jsm:233:10
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - proto.rejects/</<@resource://testing-common/Assert.jsm:477:16
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:572:13
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - @-e:1:14
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - exiting test
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - PID 3132 | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object
[task 2019-08-14T01:50:13.297Z] 01:50:13 INFO - <<<<<<<
[task 2019-08-14T01:50:13.298Z] 01:50:13 INFO - TEST-START | toolkit/components/places/tests/sync/test_bookmark_abort_merging.js

Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7f1aac9335e
Pass an already-aborted signal to avoid a race in `test_abort_merging`. a=testonly
Assignee: nobody → lina
Status: NEW → ASSIGNED
Regressed by: 1573305
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Flags: needinfo?(lina)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

SyncedBookmarksMirror::merge is racy: the storage thread might finish
merging before it gets the cancellation signal. However, apply also
notifies observers and fetches records, which happen after we've
aborted our JS controller. Even if the Rust op isn't canceled in time,
we should still abort the remaining operations.

Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e7460e2a73e
Test aborting application, not only merging. a=testonly
Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.