1573758 - Consider dropping or extending tabs TTL

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[Alessandro Surace]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

From device 1:
sync the tabs
From device 2:
Try to open the tabs from device 1.

I see my "Device 1" in the list of the Connected device.
Device 1 has been synced more that 2 months ago.

Actual results:

The device 1 is not listed in the Library --> Synced Tabs.

Expected results:

See the synced tabs and be able to open it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Thanks for reporting, and sorry you are hitting this.

For historical reasons, tabs are only kept for 21 days. However, I can't see a great reason for this any more - we should extend it to a much larger value, while also ensuring that only devices which remain connected to the account have their tabs shown (which I believe is true today). This means the user can still kill old, stale devices via the FxAccounts device list.

Comment 3

[Alessandro Surace]

Oh...:-O
yep would be great to have it for longer time.
I didn't find this documented anywhere. May be it should be.
Thanks to have clarified this.
I confirm that I see all the old connected devices...The bad things is that you cannot understand that in reality the cannot be recovered...

Comment 4

[mparker17]

Attachment: Extend tab TTL to 366 days (1 leap year)

I've written a patch that extends the TTL for tabs to 366 days (1 leap year).

Feedback is welcome; although this is my first patch to Firefox ever, and I couldn't find any docs for people who want to contribute patches, so:

• I haven't updated any automated tests (because I don't know where to find them),
• it's probably in the wrong format (sorry; I come from the Drupal Open Source Community, so I'm used to their style of patches),
• I've probably set the bug flags incorrectly (because I don't know what any of them mean), and,
• it probably doesn't conform to coding standards (because I don't know what they are)

... so your patience with me would be appreciated.

I tried setting it to "review" so that someone else with more experience would look at it and tell me what to do next.

I would be very much willing to learn to do better if someone would be able to mentor me and walk me through the process of submitting patches! Thanks!

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Hey mparker, thanks for jumping in! You might find https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction of interest - it explains how our code review process works. The patch itself looks fine, but will need to be a little different (eg, it will need to have a description etc - everything needed for it to land) - the doc above should explain that in some detail. When you upload it, flag me for review.

The r+ flag on an attachment means it has review - you can request review by setting the "?" flag, but as mentioned, now that we use phabricator there's no need to play with attachments nor the review flag directly. In the meantime I'll mark that attachment as obsolete.

Let me know if you have trouble with the phabricator instructions or the process in general and I'll do what I can to help you out (although not I'm in .au, so timezones may mean I take some time to respond)

Comment 6

[aarushivij]

Hello, can I work on this?
Also to how many days, should it be extended to?
Thanks :)
Aarushi

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Did you see comment 4? I've no problem with the ttl that chose.

Comment 8

[aarushivij]

Okay, I will submit the patch then :)

Comment 9

[aarushivij]

Attachment: Bug 1573758 - Extend TTL for syncing tabs to 1 year. r=markh

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd051fd71e1c
Extend TTL for syncing tabs to 1 year. r=markh

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bd051fd71e1c