Closed Bug 1573814 Opened 2 years ago Closed 2 years ago

Use initial `undefined` value for internal slots of Intl objects

Categories

(Core :: JavaScript: Internationalization API, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Instead of manually setting all Intl objects slots to nullptr resp. NullValue after allocation, we could simply leave them as UndefinedValue, because I don't think there's any added value being able to differentiate between null and undefined when eventually setting the slot value in initializeIntlObject.

Now that the private slot accessors already handle undefined, we might as
well keep the initial value instead of manually setting the slots to nullptr.

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eac1a1e4388
Use undefined for the initial slot values of Intl objects. r=jwalden

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.