Closed
Bug 1573814
Opened 5 years ago
Closed 5 years ago
Use initial `undefined` value for internal slots of Intl objects
Categories
(Core :: JavaScript: Internationalization API, task)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
Instead of manually setting all Intl objects slots to nullptr
resp. NullValue
after allocation, we could simply leave them as UndefinedValue
, because I don't think there's any added value being able to differentiate between null
and undefined
when eventually setting the slot value in initializeIntlObject
.
Assignee | ||
Comment 1•5 years ago
|
||
Now that the private slot accessors already handle undefined
, we might as
well keep the initial value instead of manually setting the slots to nullptr.
Assignee | ||
Comment 2•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=562c5a3bd4b4f44c784f409165a8e1a91fe8a0af
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eac1a1e4388
Use undefined
for the initial slot values of Intl objects. r=jwalden
Keywords: checkin-needed
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•