Closed Bug 1573842 Opened 3 months ago Closed 3 months ago

Should not report use counters for resource document

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr68 --- fixed
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

I found we report use counters for resource document which seems odd to me. We currently don't report the use counters for chome:* and about:*, I think we should make resource:* behave the same way as chrome:*

Assignee: nobody → echen
Priority: -- → P2
Blocks: 1572963, 1533543
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bc7660d5f16
Don't report use counters for resource document; r=smaug
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta and ESR68 approval so we can clean up the oranges affecting those branches as well.

Flags: needinfo?(echen)

Comment on attachment 9085478 [details]
Bug 1573842 - Don't report use counters for resource document;

Beta/Release Uplift Approval Request

  • User impact if declined: The use counters for resouce: get being reported. It is odd and causes intermittent failures.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch only affects the user counters for resource document won't be reported with Telemetry.
  • String changes made/needed: None
Flags: needinfo?(echen)
Attachment #9085478 - Flags: approval-mozilla-beta?

Comment on attachment 9085478 [details]
Bug 1573842 - Don't report use counters for resource document;

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: The use counters for resouce: get being reported. It is odd and causes intermittent failures.
  • User impact if declined: The use counters for resouce: get being reported. It is odd and causes intermittent failures.
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch only affects the user counters for resource document won't be reported with Telemetry.
  • String or UUID changes made by this patch: None
Attachment #9085478 - Flags: approval-mozilla-esr68?

Comment on attachment 9085478 [details]
Bug 1573842 - Don't report use counters for resource document;

Fixes up some intermittent oranges affecting all branches. Approved for 69.0b15 and 68.1esr.

Attachment #9085478 - Flags: approval-mozilla-esr68?
Attachment #9085478 - Flags: approval-mozilla-esr68+
Attachment #9085478 - Flags: approval-mozilla-beta?
Attachment #9085478 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.