Closed Bug 1573920 Opened 1 year ago Closed 5 months ago

[wpt-sync] Sync PR 18429 - [ChromeDriver] Creates new ChromeDriver SetPermission command

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18429 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18429
Details from upstream follow.

Rohan Pavone <rohpavone@chromium.org> wrote:

[ChromeDriver] Creates new ChromeDriver SetPermission command

Adds W3C WebDriver extension, SetPermission, to support simple
permissions.

Design doc: go/chromedriver-permissions-ext

Tested: Passing W3C permissions tests. Due to the relaxed definition
of the spec, the tests do not test much, so new tests were added to
run_py_tests to enfore certain behaviors.
Bug: chromedriver:2212
Change-Id: Ie61cc4c0e18c714f93ac7ab918d0cec0e4210e1e
Reviewed-on: https://chromium-review.googlesource.com/1666438
WPT-Export-Revision: 7245d7ecdd111ff40f7308a637c716f146754cb7

Component: web-platform-tests → geckodriver

Do we see some kind of infinite loop in pushing to try here?

Flags: needinfo?(james)
Flags: needinfo?(dheiberg)

Don't think it's an infinite loop, the bot keeps pushing new versions of the change, and it's marked as "approved" because it's a Chromium export, so the bot thinks that it's about to land and it should do the full try dance including stability in anticipation. It's just a faulty assumption because the Chrome changes are approved even when the Chrome-side code review isn't done.

We could stop doing stability try pushes until the change actually lands but that would affect our overall latency. dheiberg and I already talked about changes we could make here.

Flags: needinfo?(james)

Yes this doesn't seem to be a bug/infinite loop. We could consider looking into ways to maybe detect 'CI spam' of some sort, but again that may cause unwanted latency.

We are discussing reducing the amount of CI we do on our end and using the upstream Taskcluster run instead of our non stability run.

Flags: needinfo?(dheiberg)
Result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae05a3a6e419
[wpt PR 18429] - [ChromeDriver] Creates new ChromeDriver SetPermission command, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.