1573932 - Enterprise policy should be able to opt-out of extended triplets

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement)

Description

[Kate Hudson :k88hudson]

We should give Enterprise builds the option to opt-out of extended triplets via a pref if possible, since they are also able to opt-out of about:welcome.

This could be accomplished with modifying the asrouter.onboarding pref but it might be preferable to use a separate pref.

Comment 1

[Ed Lee :Mardak]

Enterprise has an OverrideFirstRunPage which I guess we can check if startup.homepage_welcome_url is set to "about:welcome"

https://searchfox.org/mozilla-central/rev/428cf94f4ddfb80eebc6028023a7d89eb277791b/browser/components/enterprisepolicies/Policies.jsm#972-975

Comment 2

[Kate Hudson :k88hudson]

If we're ok with also disabling the triplets on about:welcome, we could accomplish this if the policy set trailhead.firstrun.branches pref to control (or just join if we wanted to enable the modal)

Comment 3

[Mike Kaply [:mkaply]]

So I'm wondering when to set this pref in policy.

I'm thinking if either FirefoxHome is customized (at all) or first run page is overridden, I should set this pref.

What's control versus join?

Comment 4

[Ed Lee :Mardak]

Both "control" and "join" have about:welcome dialogs for FxA signups (with different messaging; and no triplets). Setting trailhead.firstrun.branches to "nofirstrun" will show no interrupt nor triplets on about:welcome as well as no triplets on about:newtab/home.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1573932 - Disable extended triplets for certain policies.

Comment 6

[Mike Kaply [:mkaply]]

I went with three policies that can disable them

1. if sync is turned off.
2. If they've modified the new tab page (FirefoxHome) in any way.
3. If they've changed the welcome page.

I did not add an explicit new policy.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bef138f4cafb
Disable extended triplets for certain policies. r=Mardak

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bef138f4cafb

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 9087452 [details]
Bug 1573932 - Disable extended triplets for certain policies.

Beta/Release Uplift Approval Request

• User impact if declined: Triplets appear in enterprises. Needed for Skyline.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just sets an additional preference with a couple policies.
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9087452 [details]
Bug 1573932 - Disable extended triplets for certain policies.

Allow enterprise policies to be set to opt out of new relationship scoping work shipping in 69. Approved for 69.0rc1.

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7143c324663f