WheelTransaction::Prefs should use static prefs
Categories
(Core :: Preferences: Backend, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: KrisWright, Assigned: KrisWright)
References
Details
Attachments
(1 file)
It looks like the WheelTransaction::Prefs class exists solely to create and access five prefs for WheelTransaction, initialized here: https://searchfox.org/mozilla-central/rev/3366c3d24f1c3818df37ec0818833bf085e41a53/dom/events/WheelHandlingHelper.cpp#532-546
The prefs are already generated as part of static prefs:
https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/modules/libpref/init/StaticPrefList.yaml#5445-5454,5471-5479,6150-6153
So these varcache prefs should really be removed and their usages updated. Other instances of these prefs are already using their StaticPrefs values.
|
Assignee | |
Comment 1•3 years ago
|
||
All of these prefs are already static prefs, so this removes the varcache pref definitions from WheelTransaction and replaces them with the existing static prefs.
Pushed by kwright@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77b5eec7b9e5 Remove WheelTransaction::Prefs. r=njn
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
Description
•