1573992 - Convert the various prefs in widget/* to static prefs

Status: RESOLVED FIXED

(Core :: Preferences: Backend, task)

Description

[Kris Wright :KrisWright]

There are 14 varcache prefs left defined in the widget directory, one or two to a file:

browser.tabs.remote.desktopbehavior
dom.keyboardevent.dispatch_during_composition
dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
ui.key.generalAccessKey
ui.key.chromeAccess
ui.key.contentAccess
intl.ime.hack.on_any_apps.fire_key_events_for_composition
ui.scrolling.negate_wheel_scroll
android.widget_paints_background
layout.css.devPixelsPerPx
ui.context_menus.after_mouseup
ui.use_native_colors
findbar.modalHighlight
dom.w3c_pointer_events.dispatch_by_pointer_messages

A quick search tells me that these prefs are mostly straightforward, with the bulk of them following the same pattern seen in bug 1573268.

Comment 1

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert browser.tabs.remote.desktopBehavior to static pref. r=njn

Converts browser.tabs.remote.desktopBehavior to a static pref. Updates usages.

Comment 2

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert two dom.keyboardevent.* prefs to staticprefs. r=njn

Converts dom.keyboardevent.dispatch_during_composition and dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content to static prefs. Removes the dispatch_during_composition entry from mobile.js, since it just redefines the same pref value.

Comment 3

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert 3 ui.key.* prefs to static prefs. r=njn

Converts ui.key.generalAccessKey, ui.key.chromeAccess, and ui.key.contentAccess to static prefs. Updates usages.

Comment 4

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert intl.ime.hack.on_any_apps.fire_key_events_for_composition to static pref. r=njn

Converts intl.ime.hack.on_any_apps.fire_key_events_for_composition to a static pref and updates its usages.

Comment 5

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert ui.scrolling.negate_wheel_scroll to static pref. r=njn

Converts ui.scrolling.negate_wheel_scroll to a static pref and updates its usages. This one is only enabled on android, so I used the IS_ANDROID value to fill it.

Comment 6

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert android.widget_paints_background to static pref. r=njn

Converts android.widget_paints_background to a static pref. From my understanding, this pref only matters on android, and the overridden function in nsIWidget defaults to false. Based on that I replaced the entire WidgetPaintsBackground() function with a static pref.

Comment 7

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert layout.css.devPixelsPerPx to static pref. r=njn

Converts layout.css.devPixelsPerPx to a static pref. This one was one of the slightly odd ones; some values were expecting an atomic float, so instead of defining a regular type float it is defined in StaticPrefList.yaml as an AtomicFloat. I am assuming this was the intent of the pref value all along.

Comment 8

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert ui.context_menus.after_mouseup to static pref. r=njn

Converts ui.context_menus.after_mouseup varcache pref to a static pref and removes its associated function.

Comment 9

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert ui.use_native_colors to static pref. r=njn

Converts ui.use_native_colors to a static pref and updates its usages.

Comment 10

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert findbar.modalHighlight to static pref. r=njn

Converts findbar.modalHighlight to a static pref and updates its usages.

Comment 11

[Kris Wright :KrisWright]

Attachment: Bug 1573992 - Convert dom.w3c_pointer_events.dispatch_by_pointer_messages to static pref. r=njn

Converts dom.w3c_pointer_events.dispatch_by_pointer_messages to a static pref and removes its mirror variable.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18aea5732daf
Convert browser.tabs.remote.desktopBehavior to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0c96b213ba8d
Convert two dom.keyboardevent.* prefs to staticprefs. r=njn
https://hg.mozilla.org/integration/autoland/rev/5b8559f79b94
Convert 3 ui.key.* prefs to static prefs. r=njn
https://hg.mozilla.org/integration/autoland/rev/72a0e619b7c5
Convert intl.ime.hack.on_any_apps.fire_key_events_for_composition  to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/17f6be679d8d
Convert ui.scrolling.negate_wheel_scroll to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/d3dc8d935523
Convert android.widget_paints_background to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0b5a8bc0d337
Convert layout.css.devPixelsPerPx to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/330bdf13823d
Convert ui.context_menus.after_mouseup to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/c9489f3868a0
Convert ui.use_native_colors to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/afcd59408f56
Convert findbar.modalHighlight to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/5f00f7fcd778
Convert dom.w3c_pointer_events.dispatch_by_pointer_messages to static pref. r=njn

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/18aea5732daf
https://hg.mozilla.org/mozilla-central/rev/0c96b213ba8d
https://hg.mozilla.org/mozilla-central/rev/5b8559f79b94
https://hg.mozilla.org/mozilla-central/rev/72a0e619b7c5
https://hg.mozilla.org/mozilla-central/rev/17f6be679d8d
https://hg.mozilla.org/mozilla-central/rev/d3dc8d935523
https://hg.mozilla.org/mozilla-central/rev/0b5a8bc0d337
https://hg.mozilla.org/mozilla-central/rev/330bdf13823d
https://hg.mozilla.org/mozilla-central/rev/c9489f3868a0
https://hg.mozilla.org/mozilla-central/rev/afcd59408f56
https://hg.mozilla.org/mozilla-central/rev/5f00f7fcd778