moz-phab not usable on Windows after following Firefox development setup instructions
Categories
(Conduit :: Documentation, defect)
Tracking
(Not tracked)
People
(Reporter: mars, Unassigned)
Details
Running moz-phab raises an error if Git is not findable in the Firefox development environment. Git is not installed in the Firefox build shell environment by the Firefox Windows development setup instructions. This means you can't follow the Windows setup instructions and use moz-phab from the build shell without extra work to add Git to $PATH.
The Firefox Windows development environment instructions do include installing Git so that you can then install Arcanist, but they do not tell the user how to make Git accessible in the Firefox build shell where you would run moz-phab.
It would be great if the Setting Up Arcanist instructions or the moz-phab README included adding Git to the Mozilla build shell so moz-phab will work.
An alternative solution discussed in #conduit on Slack may be to make Git optional unless you are using a moz-phab subcommand that requires it. :zalun says that you don't need Git to submit patches for review with moz-phab submit. Git is only required for moz-phab patch.
Here is the line I added to my ~/.bash_profile to get Git and moz-phab to work in the shell:
export PATH=/c/PROGRA~1/Git/bin:$PATH
looks like bug 1574009 covers code changes, moving to documentation.
|
||
Comment 2•5 years ago
|
||
The detailed Windows instructions will be published with the PyPI package, bug 1517463
Description
•