1574028 - Pink colored bookmarks and history in Android Q beta 6

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[bevis]

Attachment: Screenshot_20190815-092709.png

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:68.0) Gecko/68.0 Firefox/68.0

Steps to reproduce:

Nothing to be specific. Happens in Android Q beta 6.

Actual results:

Pink colored bookmarks and history

Expected results:

White background with black texts

Comment 1

[bevis]

Attachment: Screenshot_20190815-092420.png

Comment 2

[bevis]

Attachment: Screenshot_20190815-122940.png

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Did you enable paint flashing?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Never mind I can reproduce this on Q beta 6 running on a Pixel 2XL.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

This has also been reported to Google at https://issuetracker.google.com/issues/139090903 it may be an issue that Android should fix.

Comment 6

[bevis]

Attachment: 1984175680.png

Forgot to mention that even the background of the search engine selector from the address bar is also colored pink.

Comment 7

[raisinzero]

This happened to me in beta 5 of Android Q on a Pixel 3

Comment 8

[Ashley Rose]

Attachment: Bug 1574028: Fix ColorStateLists on Android Q

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

Thanks Ashley! Petru or Andrei please review when you have a chance.

Comment 10

[Ashley Rose]

You're welcome!

This happened because Q now loads a ColorStateListDrawable when loading an XML resource defined under res/color as a Drawable. For backwards compatibility, it falls back to loading the resource as a Drawable, but since ColorStateList and StateListDrawable both share the <selector> root tag, the fallback does not get triggered. ColorStateList falls back to magenta if an item in the state list is missing an android:color attribute.

To fix this, I added an android:color attribute to the affected XML resources, and kept the android:drawable attribute. This allows them to be loaded as a ColorStateList (which Q wraps with a ColorStateListDrawable) or as a StateListDrawable on devices before Q.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9086789 [details]
Bug 1574028: Fix ColorStateLists on Android Q

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Important UX bug.
• User impact if declined: The app would show a magenta background for various Views in Android Q.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Background color change for 3 layouts.
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: The app would show a magenta background for various Views in Android Q.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify that the search engine bar and the items in the Bookmarks and History tabs do not show a magenta background.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Background color change for 3 layouts.
• String changes made/needed:

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6879692f1dc1
Fix ColorStateLists on Android Q r=petru

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9086789 [details]
Bug 1574028: Fix ColorStateLists on Android Q

Fixes an ugly UX regression on newer betas of Android Q. Approved for Fennec 68.1b8.

Comment 14

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6879692f1dc1

Comment 15

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/facf4f64e226

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/d574e9e14ca2

Comment 17

[Laurentiu Apahidean]

I have tested the issue on the latest Firefox builds: 69.0b16 and 70.0a1 (2019-08-21) using a Google Pixel XL (Android Q Beta 6) and the issue no longer occurs. I will mark this issue accordingly. I will leave the qe-verify+ flag up until the fix is uplifted to the esr build.

Comment 18

[Andrei Jolțan [:Andi]]

Hi, verified as fixed on Firefox 68.1b8 using a Google Pixel XL (Android Q Beta 6)

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 20

[Julien Cristau [:jcristau]]

pretty sure bugbug is wrong.