1574056 - mach vendor rust should use native cargo vendor

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Cameron McCormack (:heycam)]

mach vendor rust installs cargo-vendor if it's not already installed. It does that through cargo install cargo-vendor. That fails if the libssl headers are not installed. On my Ubuntu 19.04 machine, I needed to apt install libssl-dev to get that working. mach bootstrap should install this package for me.

Comment 1

[Mike Hommey [:glandium]]

cargo vendor is a native tool now. mach vendor rust should use it instead of installing cargo-vendor. Although, looking around, it's not on release yet. Only on beta. So it should be released in 1.37... which is due... tomorrow?

That said, even considering the installation of cargo-vendor, it's not mach bootstrap's job to ensure cargo-vendor's dependencies. It's more mach vendor's job.

Comment 2

[Dzmitry Malyshau [:kvark]]

So, interestingly, with Rust 1.37 ./mach vendor rust just plain fails to me. It calls cargo vendor --quiet --sync Cargo.lock which ends up calling the standard cargo vendor, for which --sync expects a TOML file, not a LOCK file...

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1574056 - Make `mach vendor rust` use now native `cargo vendor`.

Note that cargo vendor always uses the native version even when
cargo-vendor was already installed, so there is no concern wrt that.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

For some reason, I had an issue with cargo vendor on my machine, when using mach vendor rust:

error: failed to parse manifest at `/home/ben/code/mozilla-inbound/Cargo.lock` 
Caused by:
  invalid type: map, expected a string for key `package`

I have no idea where it came from, nor did I know how to fix it. nalexander on irc spotted this patch and asked me to try it, and importing it had the issue disappear.

Comment 5

[Dzmitry Malyshau [:kvark]]

Benjamin, yes, that's what I described in Comment 2. Cargo is being fed a "Cargo.lock" file where it expects a TOML.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccd4c2bcbd7a
Make `mach vendor rust` use now native `cargo vendor`. r=chmanchester

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ccd4c2bcbd7a