Closed Bug 1574142 Opened 5 years ago Closed 5 years ago

Mochitest log spam: TypeError: undefined has no properties, line 132 UrlbarInput.jsm

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 71

People

(Reporter: Gijs, Unassigned)

References

Details

Cf:

[task 2019-08-14T12:54:42.416Z] 12:54:42     INFO - GECKO(5978) | JavaScript error: resource:///modules/UrlbarInput.jsm, line 132: TypeError: undefined has no properties

From:
https://taskcluster-artifacts.net/XnBGgoNoQtO1Cfqy0J16uA/0/public/logs/live_backing.log

Some 500 occurrences just in this log. Looks like it comes from the method forwarder, and we'd get a clearer idea of what this is if it checked whether this.textbox was alive before attempting to call methods on it, and perhaps printed a stack trace and an indication of which method we're trying to call, if it ever gets called with a null/undefined this.textbox.

While looking for this in recent autoland logs, I found this:

[task 2019-08-24T20:03:35.061Z] 20:03:35 INFO - GECKO(1083) | JavaScript error: resource:///modules/UrlbarInput.jsm, line 207: TypeError: this._inputFieldEvents is undefined

https://taskcluster-artifacts.net/PS-qSCN0SWaXgzTcTEYoUA/0/public/logs/live_backing.log

Which is this line: https://searchfox.org/mozilla-central/rev/0a6d4a24f83da7d2d2acbac919358c8499ddad2f/browser/components/urlbar/UrlbarInput.jsm#207

I didn't find the error in comment 0, but I didn't look very hard. Looks like we have something unexpected happening in tests with construction and uninit.

Priority: -- → P2

I wonder if this is still a thing, we recently simplified construction/deconstruction.

Do you remember in which mochitests this was happening, just a random mochitest-browser, the one with urlbar tests?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Marco Bonardo [:mak] from comment #2)

I wonder if this is still a thing, we recently simplified construction/deconstruction.

Do you remember in which mochitests this was happening, just a random mochitest-browser, the one with urlbar tests?

CustomizableUI tests, which opened / closed customize mode. It seems likely that this had to do with construction/deconstruction getting confused. I don't see this in logs on infra on current m-c tip anymore - do you know what bug fixed this, for completeness' sake?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mak)

I'm pretty sure it was bug 1586889

Status: NEW → RESOLVED
Closed: 5 years ago
Depends on: 1586889
Flags: needinfo?(mak)
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.