Closed Bug 1574155 Opened 4 months ago Closed 4 months ago

webdriver/tests/switch_to_frame/cross_origin.py has to use a different top-level domain and not subdomains

Categories

(Testing :: geckodriver, defect, P1)

Version 3
defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Right now the two tests use a subdomain for the cross-origin checks, which is not actually valid. Instead different top-level domains have to be used. I noticed that while working on bug 1559592, and with the patch on that bug there will be a method to use the alternative domain for inline() and iframe.

Actually given that the patch for the screenshot API might still take a bit due to not yet given feedback, I think it makes more sense to add the fixture changes for the alternative domain already here for this bug. As such I updated the patch and triggered a try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=642226f60fe4ebe087b8feebc25840086af99d10

Blocks: 1559592
No longer depends on: 1559592
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1

Using a different subdomain as host for an iframe source doesn't actually
qualify for a cross-site origin. Instead the TLD has to be different.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a61a256c7eaf
[wdspec] Use different top-level domains for cross-site iframe tests. r=webdriver-reviewers,ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18495 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Upstream PR merged by jgraham
You need to log in before you can comment on or make changes to this bug.