Closed Bug 1574246 Opened 3 months ago Closed 3 months ago

Top result's text is not visible when user types a space and arrows down past the first result

Categories

(Firefox :: Address Bar, defect, minor)

defect
Not set
minor
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 70
Iteration:
70.3 - Aug 5 - 18
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 + verified
firefox70 + verified

People

(Reporter: okonaraddi, Assigned: adw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Steps to reproduce:

  • open new tab
  • click space bar (to type a space in the urlbar input field)
  • click down arrow key twice (to select the second result)

The first result's text is not visible

Thanks for reporting this. It's probably a regression from bug 1571913.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Keywords: regression
OS: macOS → All
Regressions: 1571913
Hardware: x86_64 → All
Iteration: --- → 70.3 - Aug 5 - 18
Points: --- → 2

[Tracking Requested - why for this release]:

We uplifted bug 1571913 to 69 and it caused this regression. We should make sure this is fixed for 69.

Regressed by: 1571913
No longer regressions: 1571913
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fac77d207dbc
Quantumbar: Don't collapse secondary text for search results when the title is empty. r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Please nominate this for Beta approval when you get a chance.

Flags: qe-verify+
Flags: needinfo?(adw)
Attached patch Beta/69 patchSplinter Review

Beta/Release Uplift Approval Request

  • User impact if declined: This fixes a regression on 69.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Please see comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a one-line CSS change. I tested the patch manually.
  • String changes made/needed: None
Flags: needinfo?(adw)
Attachment #9086843 - Flags: approval-mozilla-beta?
Comment on attachment 9086843 [details] [diff] [review]
Beta/69 patch

Fixes a visual regression in Fx69 with the quantumbar. Approved for 69.0b16.
Attachment #9086843 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I reproduced this issue using Fx 70.0a1 (2019-08-15), on Windows 10 x64.
I can confirm this issue is fixed on Fx 70.0a1(2019-08-21), I verified using Windows 10 x64, Ubuntu 18.04 and macOS 10.13.6.

I have reproduced this issue in Nightly v70.0a1 from 2019-08-18 and verified the fix in Nightly v70.0a1 from 2019-08-21.

Furthermore, I have reproduced this issue on Beta v69.0b15 and verified the fix in Beta v69.0b16 buildID: 20190821111837.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.