1574316 - Show all of the data in the subpanels of the protection panel as origins not domains

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[(no longer active)]

Right now we display the Cross-Site Tracking Cookies data inside the subpanel as origins but the rest as domains. It would be really nice to show all of them as origins.

Since we probably need to take care of other things like formatting for IDNs as well it might make sense to share the code to format them for display purposes across all subpanels...

Comment 1

[Johann Hofmann [:johannh]]

Interesting, recently I was thinking that we should probably switch to displaying domains for cookies since it seems easier to parse for users. I agree that we should make it consistent, however...

Comment 2

[(no longer active)]

(In reply to Johann Hofmann [:johannh] from comment #1)

Interesting, recently I was thinking that we should probably switch to displaying domains for cookies since it seems easier to parse for users. I agree that we should make it consistent, however...

Domains are just plain wrong. For one thing, if both https://evil.example and http://evil.example are present on a page, we probably show "evil.example" in the panels that show the domain names twice (unless if we go through the effort to deduplicate).

I've never been 100% sure what this information is supposed to be used for by our users, but my expectation is that this is generally meaningless to everyone besides power users whether we use domains or origins, and for power users we should probably use what's more accurate and matches how we represent this data elsewhere in the browser UI (which also mostly displays origins in lieu of bare domains.)

Comment 3

[:ingrid]

I would like to be assigned, thank you!

Comment 4

[aarushivij]

Hello
Can I work on this issue :)
Thanks
Aarushi

Comment 5

[aarushivij]

Oh sorry I did not see it was assigned :)

Comment 6

[:prathiksha]

Hi Ingrid, I see you're already working on a different bug at the moment. I'll unassign for now. Please let me know if you're looking for more bugs to work on in the future :)

Comment 7

[Jorge]

I can take on this bug!

Comment 8

[Jorge]

Attachment: Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha

Comment 9

[Jorge]

Attachment: Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha

Comment 10

[Jorge]

Attachment: Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha Differential Revision: https://phabricator.services.mozilla.com/D66915

Comment 11

[Jorge]

Attachment: Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha

Comment 12

[Jorge]

Attachment: Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha Differential Revision: https://phabricator.services.mozilla.com/D66915

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/437249143591
Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/437249143591