Closed Bug 1574319 Opened 1 year ago Closed 1 year ago

Fix crashing ContentParent::Recv* Fission mochitests

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Fission Milestone M4
Tracking Status
firefox70 --- fixed

People

(Reporter: kashav, Assigned: kashav)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently skip 4 tests for crashing RecvDetachBrowsingContext:

The crashes don't seem to happen anymore, so we should either update the annotations or remove them altogether.

Just for extra context, the reason these crashes seem to have been fixed magically is that they were actually triggered by the parent process handling (probably completely arbitrary) content crashes (bug 1566196). Bug 1563619 should eventually fix subframe crash handling, but I think we can expect new RecvDetachBrowsingContext crashes until then.

Priority: -- → P2

The crashes don't seem to happen anymore, so we should either update the annotations or remove them altogether.

Unless I'm mistaken, the same appears to be true for RecvCacheBrowsingContextChildren crashes (there's 2 right now).

Summary: Fix crashing ContentParent::RecvDetachBrowsingContext Fission mochitests → Fix crashing ContentParent::Recv* Fission mochitests
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1cc5ee9a7db
Remove ContentParent::Recv* skip-if annotations, r=kmag
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.