Fix crashing ContentParent::Recv* Fission mochitests
Categories
(Core :: DOM: Navigation, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: u608768, Assigned: u608768)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We currently skip 4 tests for crashing RecvDetachBrowsingContext:
- https://searchfox.org/mozilla-central/rev/3a61fb322f74a0396878468e50e4f4e97e369825/docshell/test/mochitest/mochitest.ini#126
- https://searchfox.org/mozilla-central/rev/3a61fb322f74a0396878468e50e4f4e97e369825/dom/base/test/mochitest.ini#252,494
- https://searchfox.org/mozilla-central/rev/3366c3d24f1c3818df37ec0818833bf085e41a53/js/xpconnect/tests/mochitest/mochitest.ini#88
The crashes don't seem to happen anymore, so we should either update the annotations or remove them altogether.
Just for extra context, the reason these crashes seem to have been fixed magically is that they were actually triggered by the parent process handling (probably completely arbitrary) content crashes (bug 1566196). Bug 1563619 should eventually fix subframe crash handling, but I think we can expect new RecvDetachBrowsingContext crashes until then.
|
||
Updated•5 years ago
|
The crashes don't seem to happen anymore, so we should either update the annotations or remove them altogether.
Unless I'm mistaken, the same appears to be true for RecvCacheBrowsingContextChildren crashes (there's 2 right now).
Pushed by kmadan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1cc5ee9a7db Remove ContentParent::Recv* skip-if annotations, r=kmag
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•