Closed Bug 1574320 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18471 - Check requested reference space against enabled XR session features

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18471 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18471
Details from upstream follow.

Will Cassella <cassew@google.com> wrote:

Check requested reference space against enabled XR session features

Currently we only check if the requested reference space is supported
by the device before resolving the request. With more detailed consent
this is no longer sufficient, we need to also check the underlying
feature of the reference space against which features have been enabled.

This CL also does some minor refactoring of code related to
XRSessionFeature.

Bug: 985095
Change-Id: Ibe6ecadbc6ce25c523eb4ee9d8a73560d8580df5
Reviewed-on: https://chromium-review.googlesource.com/1754275
WPT-Export-Revision: 550b23334561d5a3c87dfcce33d67afef526890b

Ran 9 tests and 30[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] subtests
FAIL   : 9[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
ERROR  : 9[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
NOTRUN : 21[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]

New tests that have failures or other problems:
/webxr/xrSession_requestReferenceSpace_features.https.html
    Immersive AR session supports local space by default: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
    Immersive AR session supports local-floor space when optional: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
    Immersive AR session supports local-floor space when required: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
    Immersive AR session supports viewer space by default: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]

Tests that are disabled for instability:
/webxr/events_referenceSpace_reset.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrBoundedReferenceSpace_updates.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrFrame_getPose.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrFrame_lifetime.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrReferenceSpace_originOffsetBounded.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrSession_requestAnimationFrame_timestamp.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrSession_requestReferenceSpace_features.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
/webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a6ea3998b1
[wpt PR 18471] - Check requested reference space against enabled XR session features, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/10d1248b6fb8
[wpt PR 18471] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d4a6ea3998b1
https://hg.mozilla.org/mozilla-central/rev/10d1248b6fb8

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.