Table delete cell, column don't work

VERIFIED FIXED

Status

SeaMonkey
Composer
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: Jean-Pierre Melkonian, Assigned: Brade)

Tracking

({regression})

Trunk
PowerPC
Mac System 9.x
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.1a+) Gecko/20020713
BuildID:    2002071303

The "table delete" row , column or Cell don't work

Reproducible: Always
Steps to Reproduce:
1. Open a new page in composer
2. Create a table with default values
3. Click in one cell
4. Try "Table delete row" (Menu bar or Contextual Menu)

Actual Results:  Nothing

Expected Results:  Row deleted

"delete table", and "delete contents" works

Comment 1

16 years ago
I just tried it using 7/15 build on Mac 9.x machine and it works for me.

I deleted a row using both regular Table menu and context menu delete.

please try again.
(Reporter)

Comment 2

16 years ago
tried with 2002071608
Same thing.
JavaScript Errors:
Opening the composer i have:
Error: [Exception... "Security error"  code: "1000" nsresult: "0x805303e8
(NS_ERROR_DOM_SECURITY_ERR)"  location: "chrome://editor/content/editor.js Line:
2335"]
Source File: chrome://editor/content/editor.js
Line: 2335

After a delete row:
Error: [Exception... "Not enough arguments
[nsITableEditor.getFirstSelectedCell]"  nsresult: "0x80570001
(NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame ::
chrome://editor/content/editor.js :: GetNumberOfContiguousSelectedRows :: line
2729"  data: no]
Source File: chrome://editor/content/editor.js
Line: 2729

After a delete column:
Error: [Exception... "Not enough arguments
[nsITableEditor.getFirstSelectedCell]"  nsresult: "0x80570001
(NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame ::
chrome://editor/content/editor.js :: GetNumberOfContiguousSelectedColumns ::
line 2757"  data: no]
Source File: chrome://editor/content/editor.js
Line: 2757

After a delete Cell:
Nothing, only the contents are deleted, but i don't know waht is supposed to be
done (A join ?)
(Reporter)

Comment 3

16 years ago
When i "said opening the composer", ir's for a new page. there is no java error
opening the composer on an old page

Clicking  on "right" in table cell properties cause the following
Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED)
[nsISelectionController.scrollSelectionIntoView]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://editor/content/EdTableProps.js :: MoveSelection :: line 712"  data: no]

I think that this one is already known

Comment 4

16 years ago
This must be relatively new. Those errors are scary; if there's some new
security requirement that doesn't allow us to have missing JS params, we are
going to be in a big world of pain because that will break lots of Composer 
code.
Assignee: syd → cmanske
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

16 years ago
reassigning to Brade since she thinks it might be related to recent changes she
made
Assignee: cmanske → brade

Comment 6

16 years ago
*** Bug 157658 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 7

16 years ago
Created attachment 91681 [details] [diff] [review]
patch for fixing table api and try/catch around security call

Comment 8

16 years ago
Comment on attachment 91681 [details] [diff] [review]
patch for fixing table api and try/catch around security call

Looks fine.
If you want to save some XUL space, you should use simply "{}" instead of "new
Object()" to create new objects.
Attachment #91681 - Flags: review+

Comment 9

16 years ago
Comment on attachment 91681 [details] [diff] [review]
patch for fixing table api and try/catch around security call

sr=kin@netscape.com

Is it more efficient to do something like:

  cellObj = { value: null };

rather than using new Object()?
Attachment #91681 - Flags: superreview+
(Assignee)

Comment 10

16 years ago
new Object cleanup is covered by bug 157970

I have requested driver approval to land the fix for this since this is a
regression from 1.1alpha
Status: NEW → ASSIGNED
Keywords: regression
(Assignee)

Comment 11

16 years ago
I have checked in the patch in bug 157851 and part of this patch so I am
resolving this bug as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

16 years ago
Works now, build 2002071808

Thanks

Comment 13

16 years ago
verified per comments.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.