1574401 - Make it possible for the element picker to select elements also in oop frames

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P1)

Description

[Patrick Brosset <:pbro>]

With Fission, the element picker in the toolbox should be able to pick elements that are inside oop frames (or remote browsers in the context of the browser toolbox).

Once bug 1568825 lands, and once we get the right APIs to iterate over remote targets that we care about, then it should be easy to start the pick in all these targets at once.

2 things to solve though:

• there will be N pickers at once, which means we will need to find a way to hide all highlighters but the one corresponding to the target that the user is currently hovering
• mouse events in a parent target will block mouse events in a nested target (e.g. sub-iframe), so we will need to fix this so it doesn't happen.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1574401 - Multi-target node-picker in the browser toolbox

Comment 2

[Patrick Brosset <:pbro>]

Not working more on this at the moment beyond this early exploration. This is also blocked by bug 1574159.

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - allow reparenting

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - allow DevTools to access BrowsingContext; r=ochameau

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35927e08a557
allow DevTools to access BrowsingContext; r=ochameau

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/35927e08a557

Comment 7

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - WIP messy fix

1. send a disconnectednode with getEmbedderElement
2. fix pagestyle error;

Depends on D44133

Comment 8

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - introduce topTarget

Comment 9

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - add targetFront and parentFront to target fronts

Comment 10

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - move listRemoteFrame from targets to mainRoot and descriptors

Depends on D45366

Comment 11

[Yulia Startsev [:yulia]]

Attachment: Bug 1574401 - remove nodeFront's connectToFrame

Depends on D45367

Comment 12

[Phabricator Automation]

Comment on attachment 9091761 [details]
Bug 1574401 - add targetFront and parentFront to target fronts

Revision D45366 was moved to bug 1584107. Setting attachment 9091761 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9089334 [details]
Bug 1574401 - allow reparenting

Revision D44133 was moved to bug 1585567. Setting attachment 9089334 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9091765 [details]
Bug 1574401 - remove nodeFront's connectToFrame

Revision D45368 was moved to bug 1585567. Setting attachment 9091765 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9091762 [details]
Bug 1574401 - move listRemoteFrame from targets to mainRoot and descriptors

Revision D45367 was moved to bug 1585567. Setting attachment 9091762 [details] to obsolete.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a046846a0789
move listRemoteFrame from targets to mainRoot and descriptors r=jdescottes,ochameau
https://hg.mozilla.org/integration/autoland/rev/103be18558b0
remove nodeFront's connectToFrame r=ochameau
https://hg.mozilla.org/integration/autoland/rev/354623d3c0be
allow reparenting r=rcaliman,ochameau

Comment 17

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a046846a0789
https://hg.mozilla.org/mozilla-central/rev/103be18558b0
https://hg.mozilla.org/mozilla-central/rev/354623d3c0be

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a046846a0789
https://hg.mozilla.org/mozilla-central/rev/103be18558b0
https://hg.mozilla.org/mozilla-central/rev/354623d3c0be

Comment 19

[Patrick Brosset <:pbro>]

Thank you so much Yulia for figuring these required pieces and pushing through with landing them. I'll take it back from here and attempt to land the final part (starting the node picker in all remote frames).

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a2d9956b5b4
Multi-target node-picker in the browser toolbox r=rcaliman,gl,ochameau

Comment 21

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0a2d9956b5b4