Closed Bug 1574410 Opened 5 months ago Closed 5 months ago

A better way to add captivedetect.canonicalURL to TRR black list

Categories

(Core :: Networking: DNS, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

See https://phabricator.services.mozilla.com/D41207#1274917.

This code is a bit error-prone. We can have better code than this.

if (!excludedDomains.IsEmpty() && excludedDomains.Last() != ',') {
   excludedDomains.AppendLiteral(",");
}
excludedDomains.Append(host);
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e914ee94c854
Directly put the host of captive portal URL to TRR black list r=mt
https://hg.mozilla.org/integration/autoland/rev/22517d118b6a
Add tests to check captive portal URL is resolved by native dns r=dragana
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.