1574485 - Perma xpcshell toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | xpcshell return code: 0 when Gecko 70 merges to Beta on 2019-08-26

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Cristina Coroiu [:ccoroiu]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=faf555c221500bdf8985544b8f9b8a0785c3b119&searchStr=xpcshell&selectedJob=262007506

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262007506&repo=try&lineNumber=3031

task 2019-08-16T13:33:09.355Z] 13:33:09 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js
[task 2019-08-16T13:33:09.555Z] 13:33:09 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | xpcshell return code: 0
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - TEST-INFO took 192ms
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - >>>>>>>
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - running event loop
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | Starting check_remote
[task 2019-08-16T13:33:09.556Z] 13:33:09 INFO - (xpcshell/head.js) | test check_remote pending (2)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1574485 - Prevent test_ext_storage_idb_data_migration.js to fail in a beta build because an undefined appInfo.version has been cached. r?zombie!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

The failure is due to appInfo.version being cached as undefined before it is set by the test (by calling AddonTestUtils.createAppInfo), and an exception (raised when Services.appinfo.version.replace is being called on an undefined appinfo.version) is making the AddonManager startup to fail.

I've attached a small (test-only) patch which fixes the failure (and I verified locally that the test passes when MOZ_COMPATIBILITY_NIGHTLY is false, as in a beta build).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02be305fd209
Prevent test_ext_storage_idb_data_migration.js to fail in a beta build because an undefined appInfo.version has been cached. r=zombie

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/02be305fd209

Comment 5

[Alexandru Michis [:malexandru]]

Verified fixed as of today's central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=249f4d24ef547c74335fbcfdc61bdba17284e12a&searchStr=xpcshell&group_state=expanded

Comment 6

[Intermittent Failures Robot]

2 failures in 5073 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• linux64-shippable: 1
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1574485&startday=2019-08-19&endday=2019-08-25&tree=all