1574506 - Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P1)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

This is blocked on work to convert grips into ObjectFronts so that we can get the contextual WalkerFront when we are calling walkerFront.gripToNodeFront.

When we either have a reference to the target or the grip becomes an ObjectFront, we would have access to the getter targetFront which will allow us to get the contextual WalkerFront for the given grip.

const walkerFront = (await grip.targetFront.getFront("inspector")).walker;
const nodeFront = await walkerFront.gripToNodeFront(grip);

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1586201, we'll add a new function to get a NodeFront, in the right context, from a given element grip.
We should make sure to use this new function instead of the current gripToNodeFront in the codebase.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Bug 1577783 will do this for this callsite devtools/client/webconsole/webconsole.js#440-443

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1574506 - Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function. r=nchevobbe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bddcd12198e7
Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function. r=nchevobbe

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset bddcd12198e7 (bug 1574506) for Devtools failures in devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js. CLOSED TREE

Log;
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272453773&repo=autoland&lineNumber=1653

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bddcd12198e7292e71adba0c0fcbf127e89dda73

Backout:
https://hg.mozilla.org/integration/autoland/rev/e2176222924f2a48bcf3214702c0a66e7fa3ce37

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a8b6efcadb8
Migrate usage of gripNodeToFront to toolbox's new getNodeFrontFromNodeGrip function. r=nchevobbe

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Dorel Luca [:dluca] from comment #5)

Backed out changeset bddcd12198e7 (bug 1574506) for Devtools failures in devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js. CLOSED TREE

Log;
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272453773&repo=autoland&lineNumber=1653

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bddcd12198e7292e71adba0c0fcbf127e89dda73

Backout:
https://hg.mozilla.org/integration/autoland/rev/e2176222924f2a48bcf3214702c0a66e7fa3ce37

Fixed a typo and relanded.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5a8b6efcadb8