157453 - In full-page plug-in mode, closing the window before plug-in content is completely loaded results in crash [@ objc_msgSend]

Status: VERIFIED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Chris Petersen]

Build: 2002-07-14-05 NB

Expected Results: Window is closed and no crash occurs
What I got: Window closes but application crashes

Steps to reproduce:

1) Open a QT movie directly (to invoke full page plugin mode) in browser.Use the
url provided.

2) After plugin has been initialized but before plugin content is completely
loaded, close this window.

3) Application crashs.

Comment 1

[Chris Petersen]

Attachment: Stack trace

Comment 2

[saari (gone)]

plugin timer fires, we crash. ->bnesse

Comment 3

[Greg K.]

Confirmed using Chimera/20020715, generating identical stack.

Comment 4

[Greg K.]

(I should mention I'm using Quicktime 6 PR. Oh, look, QT 6 has just shipped.)

Comment 5

[Chris Petersen]

Any chance on getting this problem resolved soon ? 

Comment 6

[Brian Nesse (gone)]

Not unless you can reproduce it in Mach V... ;)

Comment 7

[Chris Petersen]

That's the problem, I can't...

Comment 8

[Steve Smart]

*** Bug 160915 has been marked as a duplicate of this bug. ***

Comment 9

[Chris Petersen]

Can this get nominated for 0.5 milestone ?

Comment 10

[Chris Petersen]

*** Bug 163496 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Petersen]

*** Bug 169403 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Petersen]

We should probably fix this for 0.6 since now apple has a high profile page that
contains links to three qt movies which activate full-page plugin mode.

http://www.apple.com/hotnews/articles/2002/09/digistory/

Comment 13

[Chris Petersen]

Click one of the QT "Watch the movie"  images to begin loading the movie. While
the movie is still being loaded, close the window. A crash should occur.

Comment 14

[Chris Petersen]

Wow, I can no longer reproduce this problem in the 2002-09-27-04 NB. Closing the
window while the plugin content is still loading no longer crashs the
application. Brian, should we mark this as fixed ?

Comment 15

[Mike Pinkerton (not reading bugmail)]

i fixed a bug last week where we now immediately shut down gecko when closing
the window, rather than waiting for 1 event cycle to shut it down after the
window is closed. this situation caused all sorts of nasty bugs and timing issues. 

it's much better now. i think we can mark this fixed.

Comment 16

[Chris Petersen]

Verified in the 2002-09-27-04 NB under OS 10.2.1.

Comment 17

[Brian Nesse (gone)]

Geez, first I collide with Pink... then Chris... Grrrr

The other possibility is this part of the patch for bug 154361 which disables
the timer notification when Destroy() is called on the plugin:

Index: nsPluginViewer.cpp
===================================================================
RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginViewer.cpp,v
retrieving revision 1.106.2.10.8.1
diff -u -2 -w -r1.106.2.10.8.1 nsPluginViewer.cpp
--- nsPluginViewer.cpp	16 Aug 2002 17:35:18 -0000	1.106.2.10.8.1
+++ nsPluginViewer.cpp	26 Sep 2002 17:54:45 -0000
@@ -503,4 +504,7 @@
   if(mOwner != nsnull)
   {
+    // stop the timer explicitly to reduce reference count.
+    mOwner->CancelTimer();
+
     nsIPluginInstance *inst;
     if(NS_OK == mOwner->GetInstance(inst))

But, hey, fixed is fixed...