1574608 - [wpt-sync] Sync PR 18507 - Reword test names generated by interpolation-testcommon.js

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 18507 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18507
Details from upstream follow.

Stephen McGruer <[e-mail]> wrote:

Reword test names generated by interpolation-testcommon.js

Previously the generated test names were of the form:

property foo from \<value> to \<value> at \<progress> is \<actual-value>

This read weirdly when the test failed:

property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas'

This CL re-words the test names to read like:

property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas'

Bug: 900581
Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283
Reviewed-by: Xida Chen \<[e-mail]>
Commit-Queue: Stephen McGruer \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#687653}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 18507 applied with additional changes from upstream: 92d4abd3c9f5ba2970467b540da200739af27a1f

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f2f1519561fb43d34af3576f24fdbb42e38b84

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b644def78756ce781bbc54cc7beff62c7d6bbdd

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 26 tests and 3883[linux64-qr-debug,linux64-qr-opt], 108[windows10-64-qr-debug,windows7-32-debug], 4079[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt] subtests
OK     : 24[linux64-qr-debug,linux64-qr-opt], 25[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt], 1[windows10-64-qr-debug,windows7-32-debug]
PASS   : 3818[linux64-qr-debug,linux64-qr-opt], 3882[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 100[windows10-64-qr-debug,windows7-32-debug], 3802[windows10-64-debug,windows10-64-opt], 2550[windows10-64-qr-opt,windows7-32-opt]
CRASH  : 25[windows10-64-qr-debug,windows7-32-debug]
FAIL   : 8[windows10-64-qr-debug,windows7-32-debug], 65[linux64-qr-debug,linux64-qr-opt], 1529[windows10-64-qr-opt,windows7-32-opt], 197[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 277[windows10-64-debug,windows10-64-opt]
ERROR  : 1[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt]

Tests that CRASH:
/css/css-grid/animation/grid-template-columns-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-grid/animation/grid-template-rows-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-transforms/animation/list-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-transforms/animation/matrix-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-transforms/animation/rotate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-transforms/animation/scale-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/css-transforms/animation/translate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/backdrop-filter-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/backdrop-filter-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/backdrop-filter-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/backdrop-filter-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/filter-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/filter-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/filter-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug]
/css/filter-effects/animation/filter-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-anchor-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-distance-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-path-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-path-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-path-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-path-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-path-interpolation-005.html: [windows10-64-qr-debug,windows7-32-debug]
/css/motion/animation/offset-rotate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug]
/feature-policy/experimental-features/layout-animations-disabled-tentative.html: [windows10-64-qr-debug,windows7-32-debug]
/feature-policy/experimental-features/layout-animations-enabled-tentative.html: [windows10-64-qr-debug,windows7-32-debug]

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/motion/animation/offset-path-interpolation-005.html: ERROR[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt]

(truncated for maximum comment length)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea457979a46e
[wpt PR 18507] - Reword test names generated by interpolation-testcommon.js, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/131eefb43d0e
[wpt PR 18507] - Update wpt metadata, a=testonly

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ea457979a46e
https://hg.mozilla.org/mozilla-central/rev/131eefb43d0e