[wpt-sync] Sync PR 18508 - Fix interpolation-testcommon.js on Firefox
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 18508 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/18508
Details from upstream follow.
Stephen McGruer <smcgruer@chromium.org> wrote:
Fix interpolation-testcommon.js on Firefox
The new test generation logic had some problems:
i. It produced different sets of tests on different browsers depending
on the support status. This caused difficulties comparing test results
across browsers.ii. It produced duplicate subtest names when a 'from', 'to', or
'underlying' was not supported. Duplicate subtests are a fatal error
in WPT.This CL fixes these problems by always generating the tests, and
asserting support in them.It also removes the composition code, which was unused.
Bug: 900581
Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a
Reviewed-on: https://chromium-review.googlesource.com/1758486
WPT-Export-Revision: e7ef842c1bc10e784a33b29e47957c4a9bdff635
Assignee | ||
Comment 1•5 years ago
|
||
PR 18508 applied with additional changes from upstream: 92d4abd3c9f5ba2970467b540da200739af27a1f, b8fbe50ff0cecb7503bc14f5a15eb1d5eacc47cc, 81f8d11a1844e0881e7ad0ade1da3ac367b8d607
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d02f49bdfd05f75775d4c5c0109dc8b39c207ff
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=379db0b98d501ea8edcdaecfece00f22094be75a
Assignee | ||
Comment 4•5 years ago
|
||
Ran 27 tests and 4016[linux64-qr-debug,linux64-qr-opt], 100[windows10-64-qr-debug,windows7-32-debug], 4212[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt] subtests OK : 1[windows10-64-qr-debug,windows7-32-debug], 26[linux64-qr-debug,linux64-qr-opt], 27[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-opt,windows7-32-opt] PASS : 3668[linux64-qr-debug,linux64-qr-opt], 3649[windows10-64-debug,windows10-64-opt], 3732[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 2352[windows10-64-qr-opt,windows7-32-opt] CRASH : 26[windows10-64-qr-debug,windows7-32-debug] FAIL : 480[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt], 348[linux64-qr-debug,linux64-qr-opt], 1860[windows10-64-qr-opt,windows7-32-opt], 563[windows10-64-debug,windows10-64-opt], 100[windows10-64-qr-debug,windows7-32-debug] Tests that CRASH: /css/css-grid/animation/grid-template-columns-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-grid/animation/grid-template-rows-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-sizing/animation/width-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-transforms/animation/list-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-transforms/animation/matrix-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-transforms/animation/rotate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-transforms/animation/scale-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/css-transforms/animation/translate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/backdrop-filter-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/filter-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/filter-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/filter-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug] /css/filter-effects/animation/filter-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-anchor-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-distance-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-path-interpolation-001.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-path-interpolation-002.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-path-interpolation-003.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-path-interpolation-004.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-path-interpolation-005.html: [windows10-64-qr-debug,windows7-32-debug] /css/motion/animation/offset-rotate-interpolation.html: [windows10-64-qr-debug,windows7-32-debug] /feature-policy/experimental-features/layout-animations-disabled-tentative.html: [windows10-64-qr-debug,windows7-32-debug] /feature-policy/experimental-features/layout-animations-enabled-tentative.html: [windows10-64-qr-debug,windows7-32-debug] (truncated for maximum comment length)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb469259185a [wpt PR 18508] - Fix interpolation-testcommon.js on Firefox, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/70f199060a2b [wpt PR 18508] - Update wpt metadata, a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cb469259185a
https://hg.mozilla.org/mozilla-central/rev/70f199060a2b
Description
•