Closed Bug 1574687 Opened 4 months ago Closed 4 months ago

[wpt-sync] Sync PR 18515 - Remove invalid test cases using unitless zero length in math functions

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18515 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18515
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Remove invalid test cases using unitless zero length in math functions

Spec (*) explicitly disallows unitless zero length in math functions:

Note: Because \<number-token>s are always interpreted as \<number>s or
\<integer>s, "unitless 0" \<length>s aren’t supported in math functions.
That is, 'width: calc(0 + 5px);' is invalid, because it’s trying to
add a \<number> to a \<length>, even though both 'width: 0;' and
'width: 5px;' are valid.

There are some existing WPT test cases violating this, which are
removed in this patch.

(*) https://drafts.csswg.org/css-values-4/#calc-type-checking

Bug: 994359
Change-Id: Iba66c4e425ec24133c7f70bbbeca7a60d59e1883
Reviewed-on: https://chromium-review.googlesource.com/1758734
WPT-Export-Revision: 72ebf4e1bd01f8fb4809d7c32e1f681a99686a0d

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 4 tests and 676 subtests
OK     : 4
PASS   : 616
FAIL   : 60
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78ab1e19c4af
[wpt PR 18515] - Remove invalid test cases using unitless zero length in math functions, a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.