Closed Bug 1574689 Opened 1 year ago Closed 1 year ago

Port |Bug 1379560 - Add a default permission pref in the permission manager| to SeaMonkey

Categories

(SeaMonkey :: Page Info, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.68
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 1 obsolete file)

As well as porting Bug 1379560 also remove straggling indexedDB from SitePermissions.jsm (it was removed in Bug 1334411)

Attached patch Add default permission pref (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9086211 - Flags: review?(frgrahl)
Attachment #9086211 - Flags: approval-comm-release?
Attachment #9086211 - Flags: approval-comm-esr60?
Comment on attachment 9086211 [details] [diff] [review]
Add default permission pref

permissions.default.image is exposed in the prefs ui and has a custom option (3). Is it really right to remove the default? Looks more like the old getDefault was not right?

https://dxr.mozilla.org/comm-central/source/modules/libpref/init/all.js#2264
Flags: needinfo?(iann_bugzilla)

Port parts of Bug 1543812 to allow for custom getMultichoiceStateLabel and then make use of them for 3rd option on image permissions.

Attachment #9086211 - Attachment is obsolete: true
Attachment #9086211 - Flags: review?(frgrahl)
Attachment #9086211 - Flags: approval-comm-release?
Attachment #9086211 - Flags: approval-comm-esr60?
Flags: needinfo?(iann_bugzilla)
Attachment #9088322 - Flags: review?(frgrahl)
Attachment #9088322 - Flags: approval-comm-release?
Attachment #9088322 - Flags: approval-comm-esr60?
Comment on attachment 9088322 [details] [diff] [review]
Add default permission pref and cater for image permissions

r/a=me
lgtm
Attachment #9088322 - Flags: review?(frgrahl)
Attachment #9088322 - Flags: review+
Attachment #9088322 - Flags: approval-comm-release?
Attachment #9088322 - Flags: approval-comm-release+
Attachment #9088322 - Flags: approval-comm-esr60?
Attachment #9088322 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ed0e6f56584c
Port Bug 1379560 "Add a default permission pref in the permission manager" to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.