1574736 - in Dark theme, text contrast ratio is too low for "Search with Google or enter address"

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Will]

Attachment: searchwithgoogleorenteraddress.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

in Dark theme, the text contrast ratio of "Search with Google or enter address" in the URL bar is too low, please see attached screenshot comparing Firefox light mode to dark mode (light mode has good contrast ratio)

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Will]

Theme but also Accessibility (I have good vision and an excellent calibrated display and I still can't easily or quickly make it out)

Comment 3

[Dão Gottwald [::dao]]

Attachment: Bug 1574736 - Remove obsolete urlbar and searchbar placeholder text styling. r=ntim

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/447c2f04371a
Remove obsolete urlbar and searchbar placeholder text styling. r=ntim

Comment 5

[Will]

Is this bug a duplicate or just very similar? Please take a look https://bugzilla.mozilla.org/show_bug.cgi?id=1567714

Comment 6

[Dão Gottwald [::dao]]

(In reply to Will from comment #5)

Is this bug a duplicate or just very similar? Please take a look https://bugzilla.mozilla.org/show_bug.cgi?id=1567714

It's just similar.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/447c2f04371a

Comment 8

[Dão Gottwald [::dao]]

Comment on attachment 9086687 [details]
Bug 1574736 - Remove obsolete urlbar and searchbar placeholder text styling. r=ntim

Beta/Release Uplift Approval Request

• User impact if declined: urlbar and searchbar placeholder text has low contrast on Windows when using a dark webextension themes (including our own Dark theme)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removing an obsolete CSS rule that should have been removed a long time ago
• String changes made/needed: -

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9086687 [details]
Bug 1574736 - Remove obsolete urlbar and searchbar placeholder text styling. r=ntim

CSS-only fix to improve dark mode styling. Approved for 69.0b16.

Comment 10

[Will]

This issue also applies to the separate search bar (Options > Search > Add search bar in toolbar), does this fix it for both or does the search bar also need to be fixed? (attaching screenshot in a moment)

Comment 11

[Will]

Attachment: sepsearchbar.png

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fde83fd7f052

Comment 13

[Vlad Lucaci, QA (:vlucaci)]

Confirming this issue as verified fixed on 70.0a1 (buildID: 20190821215524) and 69.0b16 (buildID: 20190821213409). Verified using Windows 10x64 , macOS 10.14.6 and Ubuntu 18.04x64.

The "Search with Google or enter address" and the separate search bar (Options > Search > Add search bar in toolbar) are now both visible while browser is in Dark Mode.