Closed Bug 1574778 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18528 - Fixed nested list item crash when list-style-type:none

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18528 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18528
Details from upstream follow.

Cathie Chen <cathiechen@igalia.com> wrote:

Fixed nested list item crash when list-style-type:none

In quirks mode, if it's nested li, markers will occupy a whole line.
If list-style-type:none, it reasonable that no child in marker.
So remove the DCHECK and make marker_inline_size zero.

Bug: 985298
Change-Id: I54281b70064a7a568ae8a3190c0244c1140462c6

Reviewed-on: https://chromium-review.googlesource.com/1749266
WPT-Export-Revision: 4b7516f9a9cef698b6149a41ba469919da220dbd

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e30261bb3546
[wpt PR 18528] - Fixed nested list item crash when list-style-type:none, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.