1574823 - XUL overlay not loading for iframe (am-copies.xul)

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[David Lechner (:dlech)]

I'm trying to migrate an extension that uses XUL overlays to TB 68 (using linux x86_64 build3 en-US). There are several overlays that just add <script/> elements and these seem to be working, but there is an overly for chrome://messenger/content/am-copies.xul that does not seem to be loading. I have a hunch this is because it is an iframe within chrome://messenger/content/AccountManager.xul rather than a top level document.

I tried to set a debug breakpoint at https://dxr.mozilla.org/comm-release/source/mail/components/extensions/parent/ext-legacy.js#178 to see if we get a callback for am-copies.xul, but I just get the error message "chrome://messenger/content/messenger.xul : Unable to run script because scripts are blocked internally." and TB becomes unusable and has to be restarted.

Ref: https://github.com/dlech/AutoSaveDraftsFolders/pull/8

Comment 1

[Geoff Lankow (:darktrojan)]

Yes, we're checking to see if the window has been seen before, instead of checking to see if the document has been seen before. That can be fixed.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1574823-overlay-docs-not-wins-1.diff

This patch won't apply on beta or ESR but let's get it reviewed first.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9086305 [details] [diff] [review]
1574823-overlay-docs-not-wins-1.diff

Review of attachment 9086305 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me, r=mkmelin

Comment 4

[John Bieling (:TbSync)]

If this is not landing in ESR, can you advice how to work around this?

Comment 5

[Geoff Lankow (:darktrojan)]

(In reply to John Bieling (TbSync) from comment #4)

If this is not landing in ESR, can you advice how to work around this?

You could reimplement the piece I'm changing in an extension's code, but that's not a very nice option.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9086305 [details] [diff] [review]
1574823-overlay-docs-not-wins-1.diff

If the patch doesn't apply, no point approving it, right. I'll stick the flags onto the right patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8519bb801394
When loading overlays, check if the document, not the window, has been seen before. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

Oh right, that's why I didn't set those flags earlier.

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: 1574823-overlay-docs-not-wins-esr1.diff

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9086349 [details] [diff] [review]
1574823-overlay-docs-not-wins-esr1.diff

Thanks.

Comment 11

[Jorg K (CEST = GMT+2)]

TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/c6392cfb16a0a321b5a4883494cb1fe3cac79408

Comment 12

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/9c2141de871f14541b45812c40c863f6798c8f28